Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: unordered lists dropdowns, more #29927

Merged
merged 3 commits into from Mar 31, 2020
Merged

Docs: unordered lists dropdowns, more #29927

merged 3 commits into from Mar 31, 2020

Conversation

cccabinet
Copy link
Contributor

@cccabinet cccabinet commented Dec 29, 2019

In #28591, the drop menu for documents and the drop menu for Navbar were fixed in an unordered list, but input-group, Nav, Button-group, and Scrollspy did the same.

@MartijnCuppens
Copy link
Member

There are still some occurrences left in the examples and in the tests.

@cccabinet cccabinet requested a review from a team as a code owner March 31, 2020 20:43
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've processed the examples and test files, LGTM now

@MartijnCuppens MartijnCuppens merged commit 43d8663 into twbs:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants