Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse animation is jittery in Firefox Android (preview and live) #30976

Open
Noisycall opened this issue Jun 7, 2020 · 8 comments
Open

Collapse animation is jittery in Firefox Android (preview and live) #30976

Noisycall opened this issue Jun 7, 2020 · 8 comments

Comments

@Noisycall
Copy link

As the title suggests, the collapse animation is jittery on firefox mobile, both the preview and live builds.

I have tested this on two devices and both have the same issue.

Here is a link to the JS Bin

This code is taken straight from the Bootstrap Demos, along with some lorem ipsum to simulate page content.

@XhmikosR
Copy link
Member

XhmikosR commented Jun 9, 2020

Firefox for Android is, unfortunately, so bad in performance. Even their latest Beta, which has improved performance, is still not as smooth as Chromium based browsers.

That being said, right now, we transition height .35s ease, which is known to not have the best performance because the GPU isn't used.

I'm not sure we can do anything, but patches are welcome.

CC @twbs/css-review in case you have any ideas.

@ffoodd
Copy link
Member

ffoodd commented Jun 9, 2020

Did anyone try to use will-change for collapses? It's supported by Firefox for Android: not quite sure it'd improve the result, but that may worth a try.

@Noisycall may you try the following pen, please: https://codepen.io/ffoodd/pen/NWxGEQQ ?

@XhmikosR
Copy link
Member

XhmikosR commented Jun 9, 2020

I don't want to use will-change TBH. I'd rather use one of the properties that work pretty well when transitioned.

@N8n5h
Copy link

N8n5h commented Jun 9, 2020

may you try the following pen, please: https://codepen.io/ffoodd/pen/NWxGEQQ ?

I'm not OP, but I have the same problem and the performance still is a bit jittery even with will-change

I'm not sure we can do anything, but patches are welcome.

Maybe using transforms? https://medium.com/outsystems-experts/how-to-achieve-60-fps-animations-with-css3-db7b98610108

@XhmikosR
Copy link
Member

XhmikosR commented Jun 9, 2020

Maybe using transforms? https://medium.com/outsystems-experts/how-to-achieve-60-fps-animations-with-css3-db7b98610108

Well, yeah, that's what I mean with properties that work well when transitioned :)

@Noisycall
Copy link
Author

Hello, sorry I haven't checked this thread in a while.

I have used transform and transition's before, but I'm not sure how I would apply that to the inbuilt bootstrap implemention.

Maybe using transforms? https://medium.com/outsystems-experts/how-to-achieve-60-fps-animations-with-css3-db7b98610108

Well, yeah, that's what I mean with properties that work well when transitioned :)

@XhmikosR
Copy link
Member

Yeah, it's not so easy to make the change but we should definitely look into it.

@XhmikosR
Copy link
Member

XhmikosR commented Dec 6, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants