Buttons in IE7 @ 2.0.3-wip #3114

Closed
zonak opened this Issue Apr 17, 2012 · 8 comments

Projects

None yet

3 participants

@zonak
zonak commented Apr 17, 2012

Did some test with IE7 and 2.0.3-wip and noticed some issues:

  • none of the buttons have any outlines
  • the height of the buttons varies depending on the content (images, text)

I even did comparison in the docs between 2.0.2 and 2.0.3-wip and the degradation of IE7 buttons is there. It even affects things like drop downs where the height between the 2 parts (main and arrow) have different heights:

https://www.dropbox.com/sh/6gml9y7vndetbrr/PSaaQINiHB/203_buttons_IE7.png

@ctalkington
Contributor

this sounds like a previous issue that I can't seem to find at this moment.

ah I mentioned it in #3020 but looks like it was something different causing that guys issue.

@ctalkington
Contributor

the outlines or borders has to do with IE7 adding a horrid black frame around buttons that have borders and such set. so IE7 has it borders removed in newer versions.

@zonak
zonak commented Apr 19, 2012

I understand that IE7 is not the perfect target but none of these issues are present in 2.0.2 so these changes are introduced in 2.0.3 which is why I believe can be resolved.

@ctalkington
Contributor

hum as far as I recall, the black border was present in 2.0.2 but yes the dropdown toggle height is something I am looking at fixing myself trying to figure out where the short fall is.

@zonak
zonak commented Apr 19, 2012

The issue is not a black border but the buttons don't have borders at all - you can compare the screenshot I included and the current live 2.0.2 version if you have a way to test with IE7.

On Apr 18, 2012, at 8:28 PM, Chris Talkingtonreply@reply.github.com wrote:

hum as far as I recall, the black border was present in 2.0.2 but yes the dropdown toggle height is something I am looking at fixing myself trying to figure out where the short fall is.


Reply to this email directly or view it on GitHub:
#3114 (comment)

@ctalkington
Contributor

yes, but if you add borders it triggers black frame some idea of MS for accessibility.

@ctalkington
Contributor

I took a shot at fixing the dropdowns (padding values were off for IE7) in pull #3138.

@mdo
Member
mdo commented Apr 24, 2012

Issues resolved. Borders are removed and it is intentional.

@mdo mdo closed this Apr 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment