New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs e.PreventDefault() #3290

Closed
pawel-dubiel opened this Issue Apr 29, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@pawel-dubiel

pawel-dubiel commented Apr 29, 2012

Would it be better to remove e.preventDefault() from there and let people decide the behaviour in their own code. For instance I would like to have hash in the url for the Backbone app.

/* TAB DATA-API
  * ============ */

  $(function () {
    $('body').on('click.tab.data-api', '[data-toggle="tab"], [data-toggle="pill"]', function (e) {
      e.preventDefault()
      $(this).tab('show')
    })
  })
@fat

This comment has been minimized.

Show comment
Hide comment
@fat

fat Apr 30, 2012

Member
$('body').off('click.tab.data-api')

trying to chose the right defaults - this seems to be the case for 90%+ - thanks though!

Member

fat commented Apr 30, 2012

$('body').off('click.tab.data-api')

trying to chose the right defaults - this seems to be the case for 90%+ - thanks though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment