Dashboard example improvements #34007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoodd
force-pushed
the
main-fod-dashboard-example-improvements
branch
from
9bb9706
to
a19f8a0
Compare
marvin-hinkley-vortx
pushed a commit
to Vortx-Inc/bootstrap
that referenced
this pull request
May 20, 2021
|
@ffoodd sorry but what do you mean by "switch the navbar to row direction" ? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33987 (sort of).
Allowing multiple links in the nav isn't needed in our example and only requires to switch the navbar to row direction. However I found a few tiny bits of things to improve, more regarding overall quality and accessibility (despite none of those fixes are mandatory).
Preview: https://deploy-preview-34007--twbs-bootstrap.netlify.app/docs/5.0/examples/dashboard/