Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify importing all vs specific plugins #34840

Merged
merged 3 commits into from Aug 30, 2021
Merged

clarify importing all vs specific plugins #34840

merged 3 commits into from Aug 30, 2021

Conversation

mariusa
Copy link
Contributor

@mariusa mariusa commented Aug 30, 2021

fix: #34673

@GeoSot
Copy link
Member

GeoSot commented Aug 30, 2021

I would add the following too

// or getting  all of the named exports for further usage
import * as bootstrap from 'bootstrap';

and would transfer the named import

// or, specify which plugins you need:
import { Tooltip, Toast, Popover } from 'bootstrap';

below import Alert from 'bootstrap/js/dist/alert'; as an alternative

@GeoSot GeoSot requested review from XhmikosR and a team August 30, 2021 11:12
@mariusa
Copy link
Contributor Author

mariusa commented Aug 30, 2021

Good points, done!

@XhmikosR XhmikosR added this to In progress in v5.1.1 via automation Aug 30, 2021
v5.1.1 automation moved this from In progress to Reviewer approved Aug 30, 2021
@XhmikosR XhmikosR merged commit 10fc1fe into twbs:main Aug 30, 2021
v5.1.1 automation moved this from Reviewer approved to Done Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.1.1
  
Done
Development

Successfully merging this pull request may close these issues.

[docs] Importing JavaScript instruction incorrect for all plugins
3 participants