New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown conflicts with jquery_ujs on Rails #4688

Closed
fabiob opened this Issue Aug 24, 2012 · 5 comments

Comments

Projects
None yet
5 participants
@fabiob

fabiob commented Aug 24, 2012

Today I upgraded my application from Bootstrap 2.0.4 to 2.1.0, and some of the hyperlinks on my dropdowns are not working anymore.

The specific issue is with hyperlinks managed by Rails' jQuery UJS: the "sign off" link uses a data attribute in order to perform a DELETE request, like this:

<a href="/app/users/sign_out" data-method="delete" rel="nofollow"><i class="icon-off"></i>Sign Off</a>

With Bootstrap 2.1.0, the link acts as if the data-method was not present, and clicking it performs a simple GET request. If I downgrade to Bootstrap 2.0.4, it works fine.

@tonybruess

This comment has been minimized.

Show comment
Hide comment
@tonybruess

tonybruess Aug 24, 2012

I am experiencing this as well

tonybruess commented Aug 24, 2012

I am experiencing this as well

@tonybruess

This comment has been minimized.

Show comment
Hide comment
@tonybruess

tonybruess Aug 25, 2012

A quick fix is to change

config.sign_out_via = :delete

to

config.sign_out_via = :get

in devise.rb

tonybruess commented Aug 25, 2012

A quick fix is to change

config.sign_out_via = :delete

to

config.sign_out_via = :get

in devise.rb

@joeframbach

This comment has been minimized.

Show comment
Hide comment
@joeframbach

joeframbach Aug 27, 2012

This is the actual root cause: #4628 and #4497. Events cannot be bound to elements in the dropdown, due to #4497.

joeframbach commented Aug 27, 2012

This is the actual root cause: #4628 and #4497. Events cannot be bound to elements in the dropdown, due to #4497.

@fat

This comment has been minimized.

Show comment
Hide comment
@fat

fat Aug 27, 2012

Member

Hey @fabiob,

Thanks for opening this issue! Unfortunately, it looks like it fails to pass the criteria neccessary for submitting to bootstrap. The following things are currently failing:

  • should include a jsfiddle/jsbin illustrating the problem if tagged with js but not a feature

For a full list of issue filing guidelines, please refer to the bootstrap issue filing guidelines.

thanks!

Member

fat commented Aug 27, 2012

Hey @fabiob,

Thanks for opening this issue! Unfortunately, it looks like it fails to pass the criteria neccessary for submitting to bootstrap. The following things are currently failing:

  • should include a jsfiddle/jsbin illustrating the problem if tagged with js but not a feature

For a full list of issue filing guidelines, please refer to the bootstrap issue filing guidelines.

thanks!

@fat fat closed this Aug 27, 2012

@excid3

This comment has been minimized.

Show comment
Hide comment
@excid3

excid3 commented Aug 30, 2012

:|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment