New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Dropdown Menu Items not clickable on iPhone #4756

Closed
ShivX opened this Issue Aug 27, 2012 · 30 comments

Comments

Projects
None yet
@ShivX

ShivX commented Aug 27, 2012

Since 2.1.0, Button dropdown menu items cannot be clicked/selected on iPhone (Unable to test on other touch devices to confirm). The dropdown menu closes as soon as you try to click an item from the dropdown.

This issue is repeatable on the Bootstrap Sample Page: http://twitter.github.com/bootstrap/components.html#buttonDropdowns

To clarify, I also applied the 4497 fix to see if that helped, and no luck: #4497

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Aug 27, 2012

Member

Closing as a dupe of #4497.

Member

mdo commented Aug 27, 2012

Closing as a dupe of #4497.

@mdo mdo closed this Aug 27, 2012

@ShivX

This comment has been minimized.

Show comment
Hide comment
@ShivX

ShivX Aug 27, 2012

The 4497 "fix" does not fix this issue though? And the issue I reported is specific to iPhone...

ShivX commented Aug 27, 2012

The 4497 "fix" does not fix this issue though? And the issue I reported is specific to iPhone...

@tonybruess

This comment has been minimized.

Show comment
Hide comment
@tonybruess

tonybruess Aug 27, 2012

+1 to what ShivX said

tonybruess commented Aug 27, 2012

+1 to what ShivX said

@mfansler

This comment has been minimized.

Show comment
Hide comment
@mfansler

mfansler Aug 27, 2012

Contributor

@markdotto probably meant to cite #4550 as the original which this issue duplicates.

Both #4550 and #4497 are included in the 2.1.1 Milestone.

Contributor

mfansler commented Aug 27, 2012

@markdotto probably meant to cite #4550 as the original which this issue duplicates.

Both #4550 and #4497 are included in the 2.1.1 Milestone.

@ShivX

This comment has been minimized.

Show comment
Hide comment
@ShivX

ShivX Aug 27, 2012

Thanks for the clarification :) 2.1.1 can't come soon enough!

ShivX commented Aug 27, 2012

Thanks for the clarification :) 2.1.1 can't come soon enough!

@martinschenk

This comment has been minimized.

Show comment
Hide comment
@martinschenk

martinschenk Sep 26, 2012

update to 2.1.1 doesn't change the problem - button dropdown menu still not clickable on iPhone and other smarphones.

martinschenk commented Sep 26, 2012

update to 2.1.1 doesn't change the problem - button dropdown menu still not clickable on iPhone and other smarphones.

@niels-s

This comment has been minimized.

Show comment
Hide comment
@niels-s

niels-s Oct 1, 2012

Updating to 2.1.1 doesn't help for me neither, is there anybody who had a successful fix?

niels-s commented Oct 1, 2012

Updating to 2.1.1 doesn't help for me neither, is there anybody who had a successful fix?

@RusAlex

This comment has been minimized.

Show comment
Hide comment
@RusAlex

RusAlex Oct 10, 2012

the same issue. iOS simulator 5.0 , iPhone and iPad as well.

RusAlex commented Oct 10, 2012

the same issue. iOS simulator 5.0 , iPhone and iPad as well.

@autoreverse

This comment has been minimized.

Show comment
Hide comment
@autoreverse

autoreverse Oct 10, 2012

Ditto on iPad

autoreverse commented Oct 10, 2012

Ditto on iPad

@TertiumQuid

This comment has been minimized.

Show comment
Hide comment
@TertiumQuid

TertiumQuid Oct 12, 2012

Broken++. Using 2.1.1, across iOS platforms.

TertiumQuid commented Oct 12, 2012

Broken++. Using 2.1.1, across iOS platforms.

@loter

This comment has been minimized.

Show comment
Hide comment
@loter

loter Oct 16, 2012

Any FIX for for this? I have found this problem yesterday, IOS5 on iPad, in Chrome and in built in browser

loter commented Oct 16, 2012

Any FIX for for this? I have found this problem yesterday, IOS5 on iPad, in Chrome and in built in browser

@luxlyny

This comment has been minimized.

Show comment
Hide comment
@luxlyny

luxlyny Oct 23, 2012

I encounter the same issue, testing on iPAD. hope this gonna be fix soon.

luxlyny commented Oct 23, 2012

I encounter the same issue, testing on iPAD. hope this gonna be fix soon.

@tkawa

This comment has been minimized.

Show comment
Hide comment
@tkawa

tkawa Oct 31, 2012

I'm on the same issue. probably fixed in this code for a while.

Add this after line 144 of js/bootstrap-dropdown.js:

    .on('touchstart.dropdown.data-api', '.dropdown-menu', function (e) { e.stopPropagation() })

tkawa commented Oct 31, 2012

I'm on the same issue. probably fixed in this code for a while.

Add this after line 144 of js/bootstrap-dropdown.js:

    .on('touchstart.dropdown.data-api', '.dropdown-menu', function (e) { e.stopPropagation() })
@luxlyny

This comment has been minimized.

Show comment
Hide comment
@luxlyny

luxlyny Nov 3, 2012

@tkawa : you make my day. Thanks a lot ! pod2g

luxlyny commented Nov 3, 2012

@tkawa : you make my day. Thanks a lot ! pod2g

@tkawa

This comment has been minimized.

Show comment
Hide comment
@tkawa

tkawa Nov 3, 2012

I had not noticed, the same code has been written on #4550. see there for details.

tkawa commented Nov 3, 2012

I had not noticed, the same code has been written on #4550. see there for details.

@antonmedv

This comment has been minimized.

Show comment
Hide comment
@antonmedv

antonmedv commented Dec 4, 2012

@tkawa thanks!!!

@iTeaTin

This comment has been minimized.

Show comment
Hide comment
@iTeaTin

iTeaTin Dec 5, 2012

@tkawa YOU RULE. THANK YOU.

iTeaTin commented Dec 5, 2012

@tkawa YOU RULE. THANK YOU.

@jessedobbelaere

This comment has been minimized.

Show comment
Hide comment
@jessedobbelaere

jessedobbelaere commented Dec 28, 2012

@tkawa Thanks!

@beurre

This comment has been minimized.

Show comment
Hide comment
@beurre

beurre Jan 16, 2013

Hi!
was the problem solved with the 2.2.2?

beurre commented Jan 16, 2013

Hi!
was the problem solved with the 2.2.2?

@Yohn

This comment has been minimized.

Show comment
Hide comment
@Yohn

Yohn Jan 16, 2013

Contributor

@beurre yes and no. they added the touchstart work around but it also introduced a few other bugs. I believe they're trying to work something out for the next release

Contributor

Yohn commented Jan 16, 2013

@beurre yes and no. they added the touchstart work around but it also introduced a few other bugs. I believe they're trying to work something out for the next release

@beurre

This comment has been minimized.

Show comment
Hide comment
@beurre

beurre Jan 16, 2013

@Yohn thank you! let's see then.

beurre commented Jan 16, 2013

@Yohn thank you! let's see then.

@orokusaki

This comment has been minimized.

Show comment
Hide comment
@orokusaki

orokusaki May 24, 2013

This is still an issue on iPhone, using the latest version downloaded from the website.

orokusaki commented May 24, 2013

This is still an issue on iPhone, using the latest version downloaded from the website.

@occammd

This comment has been minimized.

Show comment
Hide comment
@occammd

occammd May 25, 2013

I noticed problems again with iphone

occammd commented May 25, 2013

I noticed problems again with iphone

@portalsinc

This comment has been minimized.

Show comment
Hide comment
@portalsinc

portalsinc May 25, 2013

Same here, iPhone 4s with Bootstrap 2.3.2

portalsinc commented May 25, 2013

Same here, iPhone 4s with Bootstrap 2.3.2

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert May 26, 2013

Member

@orokusaki @occammd @portalsinc: This issue is way too ancient. Y'all want #7968.

Member

cvrebert commented May 26, 2013

@orokusaki @occammd @portalsinc: This issue is way too ancient. Y'all want #7968.

@portalsinc

This comment has been minimized.

Show comment
Hide comment
@portalsinc

portalsinc May 27, 2013

@cvrebert Thanks, Chris. #7968 it is.

portalsinc commented May 27, 2013

@cvrebert Thanks, Chris. #7968 it is.

@arcoder

This comment has been minimized.

Show comment
Hide comment
@arcoder

arcoder May 28, 2013

Problem repeats on iphone5.

Alberto

arcoder commented May 28, 2013

Problem repeats on iphone5.

Alberto

@PriyankaVK

This comment has been minimized.

Show comment
Hide comment
@PriyankaVK

PriyankaVK Aug 31, 2013

I was searching for the fix from yesterday, and your solution work like a charm!!
Thanks a lot tkawa!!!

PriyankaVK commented Aug 31, 2013

I was searching for the fix from yesterday, and your solution work like a charm!!
Thanks a lot tkawa!!!

mvcatsifma pushed a commit to mvcatsifma/mapps-styles that referenced this issue Dec 6, 2013

Fixes #4550: Temporary fix for dropdown taps on mobile
* Fix as documented here: twbs/bootstrap#4756 (comment)
* Stops propagation for touchstart for dropdowns
@miguegaete

This comment has been minimized.

Show comment
Hide comment
@miguegaete

miguegaete Jul 15, 2014

In your dropdown.js file looks the following string:

"ontouchstart"

and replace by:

"disable-ontouchstart"

This is the ultimate solution to this problem.

miguegaete commented Jul 15, 2014

In your dropdown.js file looks the following string:

"ontouchstart"

and replace by:

"disable-ontouchstart"

This is the ultimate solution to this problem.

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Jul 15, 2014

Member

Locking since this issue is rather old and about now-unsupported Bootstrap v2.

Member

cvrebert commented Jul 15, 2014

Locking since this issue is rather old and about now-unsupported Bootstrap v2.

@twbs twbs locked and limited conversation to collaborators Jul 15, 2014

malducin-vfxfan pushed a commit to malducin-vfxfan/mocon-cms that referenced this issue Feb 24, 2015

Manuel Alducin
Fix Bootstrap dropdown taps on mobile
Implemented the temporary fix for Bootstrap dropdown taps on mobile
browsers, which prevented things like dropdown menus to work
correctly.

Github issue 4550. References:

twbs/bootstrap#4550
twbs/bootstrap@ed74992
twbs/bootstrap#4756 (comment)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.