Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

.breadcrumb .divider styling inheritance broke on recent change #6136

Closed
fleaflicker opened this Issue Dec 5, 2012 · 0 comments

Comments

Projects
None yet
2 participants
@ghost

ghost commented Dec 5, 2012

Commit 869b69c changed the inhertiance rules applied to breadcrumbs.

The change applied to dividers doesn't make sense: if the breadcrumb root is a UL element, its immediate children can only be LI elements.

In the docs (and likely in all existing TwBS applications) dividers were rendered as SPANs within LIs.

Simple fix would be to remove the > preceding the .divider class, or to nest the entire definition within the li style.

example:

<ul class="breadcrumb">
  <li><a href="#">Home</a> <span class="divider">/</span></li>
  <li class="active">Library</li>
</ul>

@mdo mdo closed this in 2c7ab23 Dec 7, 2012

@stempler stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014

@mdo mdo (less) Fixes #6136: Proper scoping of breadcrumbs divider b411b69

@stempler stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014

@mdo mdo (less) Fixes #6136: Proper scoping of breadcrumbs divider 57dee9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment