Unnecessary pagination div? #6562

Closed
leeaston opened this Issue Jan 12, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@leeaston

Does pagination really need an extra div round it, can't the classes be applied directly to the ul?

http://twitter.github.com/bootstrap/components.html#pagination

@mdo mdo referenced this issue Jan 12, 2013

Merged

WIP: Bootstrap 3 #6342

120 of 126 tasks complete
@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Jan 12, 2013

Member

Thanks for calling this out—keep it up :). It's good to have a sanity check on these kinds of changes with 3.0.

It's for center or right aligning the ul within it for easy alignment. In 3.0, I'm going to take it out though because this should just be done as folks need it to be within their own applications/sites. We don't need to provide code for every situation :).

Member

mdo commented Jan 12, 2013

Thanks for calling this out—keep it up :). It's good to have a sanity check on these kinds of changes with 3.0.

It's for center or right aligning the ul within it for easy alignment. In 3.0, I'm going to take it out though because this should just be done as folks need it to be within their own applications/sites. We don't need to provide code for every situation :).

@mdo mdo closed this Jan 12, 2013

@mdo mdo reopened this Jan 12, 2013

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Jan 12, 2013

Member

Resolved in 7a3f078.

Member

mdo commented Jan 12, 2013

Resolved in 7a3f078.

@mdo mdo closed this Jan 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment