Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary pagination div? #6562

Closed
leeaston opened this issue Jan 12, 2013 · 2 comments
Closed

Unnecessary pagination div? #6562

leeaston opened this issue Jan 12, 2013 · 2 comments
Labels
Milestone

Comments

@leeaston
Copy link

@leeaston leeaston commented Jan 12, 2013

Does pagination really need an extra div round it, can't the classes be applied directly to the ul?

http://twitter.github.com/bootstrap/components.html#pagination

@mdo mdo mentioned this issue Jan 12, 2013
120 of 126 tasks complete
@mdo
Copy link
Member

@mdo mdo commented Jan 12, 2013

Thanks for calling this out—keep it up :). It's good to have a sanity check on these kinds of changes with 3.0.

It's for center or right aligning the ul within it for easy alignment. In 3.0, I'm going to take it out though because this should just be done as folks need it to be within their own applications/sites. We don't need to provide code for every situation :).

@mdo mdo closed this Jan 12, 2013
@mdo mdo reopened this Jan 12, 2013
@mdo
Copy link
Member

@mdo mdo commented Jan 12, 2013

Resolved in 7a3f078.

@mdo mdo closed this Jan 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants