New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty label doesn't collapse #9241

Closed
ZekeLu opened this Issue Aug 8, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@ZekeLu

ZekeLu commented Aug 8, 2013

It's a regression bug of #5775
Here is the empty label in bootstrap 3 RC1: http://jsfiddle.net/uDZh3/
And here is the empty label in bootstrap 2.3.2: http://jsfiddle.net/U9Zwr/

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Aug 9, 2013

Member

@ZekeLu RC 1 is kinda old. Please re-check against the current git HEAD revision.

Member

cvrebert commented Aug 9, 2013

@ZekeLu RC 1 is kinda old. Please re-check against the current git HEAD revision.

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Aug 10, 2013

Member

Just checked myself with the latest and it works fine for me in Chrome.

Member

mdo commented Aug 10, 2013

Just checked myself with the latest and it works fine for me in Chrome.

@mdo mdo closed this Aug 10, 2013

@ZekeLu

This comment has been minimized.

Show comment
Hide comment
@ZekeLu

ZekeLu Aug 11, 2013

Thank you very much!

I did checked the current git HEAD revision. But what I checked was the labels.less file rather than the bootstrap.css file. I can't find something like .label:empty{display:none;} in the labels.less file, that's why I reported this issue. I will check the bootstrap.css file instead in the future.

I just checked the latest bootstrap.css file and it seems that the issue has not been fixed. Using the latest version, a label should be written as <span class="label label-default"></span> (the class label-default is added). BANG! The empty label shows up again.

ZekeLu commented Aug 11, 2013

Thank you very much!

I did checked the current git HEAD revision. But what I checked was the labels.less file rather than the bootstrap.css file. I can't find something like .label:empty{display:none;} in the labels.less file, that's why I reported this issue. I will check the bootstrap.css file instead in the future.

I just checked the latest bootstrap.css file and it seems that the issue has not been fixed. Using the latest version, a label should be written as <span class="label label-default"></span> (the class label-default is added). BANG! The empty label shows up again.

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Aug 11, 2013

Member

Confirmed that it's not collapsing: http://jsfiddle.net/6ppaZ/5/

Member

cvrebert commented Aug 11, 2013

Confirmed that it's not collapsing: http://jsfiddle.net/6ppaZ/5/

@cvrebert cvrebert reopened this Aug 11, 2013

@mdo mdo closed this in 6b6241f Aug 11, 2013

stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014

stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment