New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts Have Uneven Padding #9310

Closed
jkcclemens opened this Issue Aug 10, 2013 · 6 comments

Comments

Projects
None yet
4 participants
@jkcclemens

I'm not sure if this is intentional, but the right-padding of alerts is 35px, while the left padding is 15px, and this makes all alerts look uneven.

Default (35px):
35px;

Fixed (15px):
15px;

If this is intentional, please let me know why, if not, I'd appreciate a fix.

Thank you!

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Aug 11, 2013

Member

It's intentional for dismiss buttons (an x) on the right side.

Member

mdo commented Aug 11, 2013

It's intentional for dismiss buttons (an x) on the right side.

@mdo mdo closed this Aug 11, 2013

@jkcclemens

This comment has been minimized.

Show comment
Hide comment
@jkcclemens

jkcclemens Aug 11, 2013

Well, it's quite annoying if you're not using a dismiss button. Perhaps you could implement a class for if you'll be using a dismiss button (or if you won't be), like "alert-dismiss" or "alert-nodismiss." Although that last one doesn't really follow naming conventions. Either way, it'd be great if I didn't have to go ahead and custom style any alert that doesn't have a dismiss button so that it will be properly centered.

Well, it's quite annoying if you're not using a dismiss button. Perhaps you could implement a class for if you'll be using a dismiss button (or if you won't be), like "alert-dismiss" or "alert-nodismiss." Although that last one doesn't really follow naming conventions. Either way, it'd be great if I didn't have to go ahead and custom style any alert that doesn't have a dismiss button so that it will be properly centered.

mdo added a commit that referenced this issue Aug 12, 2013

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Aug 12, 2013

Member

Sold! just made the change.

Member

mdo commented Aug 12, 2013

Sold! just made the change.

@jkcclemens

This comment has been minimized.

Show comment
Hide comment
@jkcclemens

jkcclemens Aug 12, 2013

You're awesome. Thanks. :D

You're awesome. Thanks. :D

@realtebo

This comment has been minimized.

Show comment
Hide comment
@realtebo

realtebo Aug 14, 2013

+1 for this fix, thanks

+1 for this fix, thanks

stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014

(less) fixes #9310: alerts aren't dismissable by default, now require…
…s .alert-dismissable if you need a close button

stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014

(less) fixes #9310: alerts aren't dismissable by default, now require…
…s .alert-dismissable if you need a close button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment