New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal remote URL loaded into wrong div #9459

Closed
gabel opened this Issue Aug 14, 2013 · 5 comments

Comments

Projects
None yet
4 participants
@gabel

gabel commented Aug 14, 2013

This is broken now....

The remote url got loaded into the .modal div directly, not in the .modal-content

http://jsfiddle.net/H5XhK/1/

Got broken by 89b3cb0 to fix #9318

@cvrebert

This comment has been minimized.

Member

cvrebert commented Aug 14, 2013

Some context: See middle paragraph of issue comment: #9318 (comment)

@cjkoll

This comment has been minimized.

cjkoll commented Aug 16, 2013

I have found your problem see below in the link you have href="/ just change it it href="
href="/api/user/gabel/demo/list.json">Launch modal

@fat

This comment has been minimized.

Member

fat commented Aug 17, 2013

from the docs:

injected into the root of the modal element

this has changed in 3.0 – in 2 it used to be body

@fat fat closed this Aug 17, 2013

@cvrebert

This comment has been minimized.

Member

cvrebert commented Aug 19, 2013

The new hierarchy is:

  • .modal
    • .modal-dialog
      • .modal-content
        • .modal-header
        • .modal-body
        • .modal-footer

The suggestion is that .modal-content makes more sense than .modal, since everything interesting is under .modal-content, and .modal & .modal-dialog typically won't directly contain custom content.

@fat

This comment has been minimized.

Member

fat commented Dec 19, 2013

ah yeah makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment