New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-close collapsing navbar menu when menu item clicked #10540

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@ebird2211

ebird2211 commented Sep 9, 2013

Added an optional event handler to auto-close the collapsing navbar menu when a menu selection is clicked (add "auto" to navbar-collapse, like <div class="collapse navbar-collapse auto">)

Update dropdown.js
Added two event handlers to auto-close the collapsing navbar menu when (a) a menu selection is clicked and (b) a click somewhere outside the menu occurs
@ebird2211

This comment has been minimized.

Owner

ebird2211 commented on js/dropdown.js in f2280b3 Sep 9, 2013

No idea if these event handlers fit in here from an architectural view, but they work for me, at least ;-)

@cvrebert

This comment has been minimized.

Member

cvrebert commented Sep 9, 2013

You need to add spaces around the curly braces.

@ebird2211

This comment has been minimized.

ebird2211 commented Sep 9, 2013

Being somehow new to this platform: is it possible to modify this after issuing the pull request?

Update dropdown.js
Added event handler to auto-close a collapsible navbar on menu selection.
Simply add the class "auto" to navbar-collapse and voila...
<div class="collapse navbar-collapse auto">
@fat

This comment has been minimized.

Member

fat commented Dec 24, 2013

don't want to bake in single page app stuff directly to the plugins… think this can safely live outside the plugin.thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment