Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options of sizes added in modal #11162

Merged
merged 2 commits into from Dec 15, 2013

Conversation

@felipefialho
Copy link
Contributor

felipefialho commented Oct 18, 2013

Hey Friends,

This time I believe the branches are organized correctly. =p

I imagine it would be interesting other size options for modal. I usually to add this option in my projects.

I added this functionality in modal and the possibility of set the size in "variables".

Thanks ; )

// Define small size for the modal
&.modal-sm{
width: @modal-sm;
}

This comment has been minimized.

Copy link
@mdo

mdo Oct 21, 2013

Member

You don't need to chain these classes here—just set them after the .modal-dialog rules.

Also, include a space before those {s and drop the comments—they're not all that helpful since the classes are pretty clear.

This comment has been minimized.

Copy link
@felipefialho

felipefialho Oct 21, 2013

Author Contributor

Really, I had put the class in the wrong place , sorry for error :p

@mdo

This comment has been minimized.

Copy link
Member

mdo commented Oct 21, 2013

Beyond adding the code here, we'll need to mention these (with classes and examples) in the docs.

I'd also probably change the small to 300px so that it lines up great on iOS with 10px of gutter. No specific thoughts on 900px for the large one other than that seems rather... large.

@felipefialho

This comment has been minimized.

Copy link
Contributor Author

felipefialho commented Oct 21, 2013

@mdo How are you?

I followed your instructions, but the large sizes continues with 900px, if you want this size is smaller I make the adjustment.

You check if this is correct?

Thanks and congratulations for this awesome project.

@jh3y

This comment has been minimized.

Copy link

jh3y commented Nov 8, 2013

Without taking a look at modal, is it possible to use responsize sizes? so % instead of px for set sizes instead?

This makes things a lot better than defining set sizes. Also this would then be more suitable cross device as small is small on all devices etc.

@jheytompkins

@mdo mdo merged commit 89e0f16 into twbs:master Dec 15, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
@mdo mdo referenced this pull request Dec 15, 2013
@cvrebert

This comment has been minimized.

Copy link
Member

cvrebert commented Dec 15, 2013

Documented in d79431c.

@pholly

This comment has been minimized.

Copy link

pholly commented Feb 7, 2014

I also do something similar in my projects.
Shouldn't .modal-lg of 900px only be for viewports larger than 900px, like at the default responsive breakpoint of 992px?

@cvrebert

This comment has been minimized.

Copy link
Member

cvrebert commented Feb 7, 2014

@pholly That's been addressed in a more recent pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.