Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

mark .box-shadow() mixin as deprecated #12398

Merged
merged 1 commit into from

2 participants

@cvrebert
Owner

Fixes #12396.

@mdo mdo merged commit 16fd8cd into master
@mdo mdo deleted the deprecate-box-shadow-mixin branch
This was referenced
@stempler stempler referenced this pull request from a commit in stempler/bootstrap
@mdo mdo (less) Merge pull request #12398 from twbs/deprecate-box-shadow-mixin
mark .box-shadow() mixin as deprecated
920161c
@stempler stempler referenced this pull request from a commit in stempler/bootstrap
@mdo mdo (less) Merge pull request #12398 from twbs/deprecate-box-shadow-mixin
mark .box-shadow() mixin as deprecated
38a35c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 27, 2014
  1. @cvrebert
This page is out of date. Refresh to see the latest.
Showing with 6 additions and 1 deletion.
  1. +2 −1  docs/css.html
  2. +4 −0 less/mixins.less
View
3  docs/css.html
@@ -2989,7 +2989,8 @@ <h3 id="less-mixins-rounded-corners">Rounded corners</h3>
{% endhighlight %}
<h3 id="less-mixins-box-shadow">Box (Drop) shadows</h3>
- <p>If your target audience is using the latest and greatest browsers and devices, be sure to just use the <code>box-shadow</code> property on its own. If you need support for older Android (pre-v4) and iOS devices (pre-iOS 5), use the mixin to pick up the required <code>-webkit</code> prefix.</p>
+ <p>If your target audience is using the latest and greatest browsers and devices, be sure to just use the <code>box-shadow</code> property on its own. If you need support for older Android (pre-v4) and iOS devices (pre-iOS 5), use the <strong>deprecated</strong> mixin to pick up the required <code>-webkit</code> prefix.</p>
+ <p>The mixin is <strong>deprecated</strong> as of v3.1.0, since Bootstrap doesn't officially support the outdated platforms that don't support the standard property. To preserve backwards-compatibility, Bootstrap will continue to use the mixin internally until Bootstrap v4.</p>
<p>Be sure to use <code>rgba()</code> colors in your box shadows so they blend as seamlessly as possible with backgrounds.</p>
{% highlight css %}
.box-shadow(@shadow: 0 1px 3px rgba(0,0,0,.25)) {
View
4 less/mixins.less
@@ -115,6 +115,10 @@
}
// Drop shadows
+//
+// Note: Deprecated `.box-shadow()` as of v3.1.0 since all of Bootstrap's
+// supported browsers that have box shadow capabilities now support the
+// standard `box-shadow` property.
.box-shadow(@shadow) {
-webkit-box-shadow: @shadow; // iOS <4.3 & Android <4.1
box-shadow: @shadow;
Something went wrong with that request. Please try again.