New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UMD tests #13843

Closed
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@hnrch02
Member

hnrch02 commented Jun 17, 2014

As suggested in #13811, here are tests/examples of using Bootstrap with RequireJS and Browserify. Both working with the concatenated file and using individual plugins is being demonstrated.

This also includes a fix for #13812, which removes the module definitions from the individual plugins and wraps them all in one big factory function. It's pretty hacky so I'd like to get feedback on it.

/cc @fat @cvrebert @XhmikosR

@cvrebert cvrebert added the js label Jun 17, 2014

@cvrebert cvrebert added this to the v3.2.0 milestone Jun 17, 2014

@hnrch02

This comment has been minimized.

Show comment
Hide comment
@hnrch02

hnrch02 Jun 17, 2014

Member

Added Browserify tests. Not sure whether or not to include the bundle.js that browserify generates, I included it for now.

Member

hnrch02 commented Jun 17, 2014

Added Browserify tests. Not sure whether or not to include the bundle.js that browserify generates, I included it for now.

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jun 17, 2014

Member

I can't comment on all the changes at the moment but see #13842 (comment)

Member

XhmikosR commented Jun 17, 2014

I can't comment on all the changes at the moment but see #13842 (comment)

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Jun 18, 2014

Member

@hnrch02 Please rebase; this currently has merge conflicts.

Member

cvrebert commented Jun 18, 2014

@hnrch02 Please rebase; this currently has merge conflicts.

@hnrch02

This comment has been minimized.

Show comment
Hide comment
@hnrch02

hnrch02 Jun 18, 2014

Member

Should be rebased now.

I want to know if the level of hackyness is acceptable and if not how we could improve it.

Member

hnrch02 commented Jun 18, 2014

Should be rebased now.

I want to know if the level of hackyness is acceptable and if not how we could improve it.

@hnrch02

This comment has been minimized.

Show comment
Hide comment
@hnrch02

hnrch02 Jun 18, 2014

Member

Rebased again, now that #13842 has been merged.

Member

hnrch02 commented Jun 18, 2014

Rebased again, now that #13842 has been merged.

Show outdated Hide outdated Gruntfile.js
@hnrch02

This comment has been minimized.

Show comment
Hide comment
@hnrch02

hnrch02 Jun 18, 2014

Member

I'll squash the commits once this is ready to merge.

Member

hnrch02 commented Jun 18, 2014

I'll squash the commits once this is ready to merge.

@hnrch02

This comment has been minimized.

Show comment
Hide comment
@hnrch02

hnrch02 Jun 19, 2014

Member

Also added the fix to concatenated files built using the customizer.

Member

hnrch02 commented Jun 19, 2014

Also added the fix to concatenated files built using the customizer.

@hnrch02

This comment has been minimized.

Show comment
Hide comment
@hnrch02

hnrch02 Jun 25, 2014

Member

So how are we gonna go about this? Will we revert the revert after 3.2 is released and work from there or are we moving the UMD stuff to a separate branch?

Member

hnrch02 commented Jun 25, 2014

So how are we gonna go about this? Will we revert the revert after 3.2 is released and work from there or are we moving the UMD stuff to a separate branch?

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Aug 2, 2014

Member

Punting to v4 checklist.

Member

mdo commented Aug 2, 2014

Punting to v4 checklist.

@mdo mdo closed this Aug 2, 2014

@mdo mdo removed this from the v4.0.0 milestone Aug 2, 2014

@mdo mdo referenced this pull request Aug 19, 2015

Closed

v4 #17021

114 of 208 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment