Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upProperly hide checkbox and radio inputs in button groups #14559
Conversation
This comment has been minimized.
This comment has been minimized.
|
Elsewhere, we're currently using |
This comment has been minimized.
This comment has been minimized.
Interestingly, the article linked in the explanatory comment for the
I suppose so, yes.
Will do. |
475152a
This comment has been minimized.
This comment has been minimized.
|
Nice, this sounds reasonable to me. Thanks for updating that comment, too. I'd love to hear more about the |
This comment has been minimized.
This comment has been minimized.
|
I don't have any experience with |
This comment has been minimized.
This comment has been minimized.
|
Just one more question—this means we don't need to revert the commit mentioned in #14137 (comment), right? If not, merge away @hnrch02! |
This comment has been minimized.
This comment has been minimized.
|
Nope, that would just have been a dirty workaround. |
This comment has been minimized.
This comment has been minimized.
|
@cvrebert Comment wording LGTY? |
This comment has been minimized.
This comment has been minimized.
|
Comment looks great to me. |
…x-n-radio Properly hide checkbox and radio inputs in button groups
This comment has been minimized.
This comment has been minimized.
|
Woohoo, first merge |
This comment has been minimized.
This comment has been minimized.
|
Aww yeah. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Sure, was wondering how that is handled. Always thought it was a bot due to the insane speed of @cvrebert. |
This comment has been minimized.
This comment has been minimized.
|
The cross reference in the timeline here will always show up as @cvrebert since he opened that issue. Anytime you merge something worth noting, you should update the ship list. And on the note of it being a bot, I'd love it if it was done by us at GitHub, but that's for another time :). |
This comment has been minimized.
This comment has been minimized.
|
Got it. And looking forward to more GitHub awesomeness in the future. |
…oup-checkbox-n-radio Properly hide checkbox and radio inputs in button groups
hnrch02 commentedSep 7, 2014
pointer-events: none;for modern browsers (including IE11+),clip: rect(1px, 1px, 1px, 1px);for everything else.Maybe @mdo can give some input on
clip, I found various resources online promoting1px, 1px, 1px, 1pxinstead of0, 0, 0, 0.Fixes #14137.
Per #14137 (comment).