New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly hide checkbox and radio inputs in button groups #14559
Properly hide checkbox and radio inputs in button groups #14559
Conversation
|
Elsewhere, we're currently using |
Interestingly, the article linked in the explanatory comment for the
I suppose so, yes.
Will do. |
`pointer-events: none;` for modern browsers (including IE11+), `clip: rect(1px, 1px, 1px, 1px);` for everything else. Fixes twbs#14137
23c2a23
to
475152a
Compare
|
Nice, this sounds reasonable to me. Thanks for updating that comment, too. I'd love to hear more about the |
|
I don't have any experience with |
|
Just one more question—this means we don't need to revert the commit mentioned in #14137 (comment), right? If not, merge away @hnrch02! |
|
Nope, that would just have been a dirty workaround. |
|
@cvrebert Comment wording LGTY? |
|
Comment looks great to me. |
…x-n-radio Properly hide checkbox and radio inputs in button groups
|
Woohoo, first merge 🎉 |
|
Aww yeah. |
|
Sure, was wondering how that is handled. Always thought it was a bot due to the insane speed of @cvrebert. |
|
The cross reference in the timeline here will always show up as @cvrebert since he opened that issue. Anytime you merge something worth noting, you should update the ship list. And on the note of it being a bot, I'd love it if it was done by us at GitHub, but that's for another time :). |
|
Got it. And looking forward to more GitHub awesomeness in the future. 😁 |
…oup-checkbox-n-radio Properly hide checkbox and radio inputs in button groups
pointer-events: none;for modern browsers (including IE11+),clip: rect(1px, 1px, 1px, 1px);for everything else.Maybe @mdo can give some input on
clip, I found various resources online promoting1px, 1px, 1px, 1pxinstead of0, 0, 0, 0.Fixes #14137.
Per #14137 (comment).