-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jekyll to v2.4.0 and rouge to v1.7.2. #14746
Conversation
I think we had been blocking on github/pages-gem#75 , but that's now been implemented. 😄 |
I think GitHub pages is using 2.4.0 too https://github.com/github/pages-gem/blob/master/lib/github-pages.rb#L10 |
Yeah, they are running 2.4.0. See https://pages.github.com/versions/. |
@hnrch02: I'm pretty sure they generate that page from the file I linked above :) I'm hitting an issue on Windows with 2.4.0;
I'll check if this issue is reported upstream... |
OK, it seems it's jekyll/jekyll#2926, |
Have you added the wdm gem as mentioned on http://jekyllrb.com/docs/windows/ ? |
Ofc @cvrebert, that's Jekyll 101 :P |
OK, just covering all the bases. :P |
@juthilo: maybe you could mention this workaround on your guide? I'm not sure if/when it will be fixed upstream... |
@juthilo Note that it's |
@parkr: you probably meant to CC me I guess :P So any ideas why this is caused? I will say it again, feel free to CC me before any release (as long as you have a gem published) to do some tests on my Windows machine. It seems things break quite often. |
Whoops! Yep. :)
Man, I wish I knew. I know it's on Listen's end (or wdm's end), and not Jekyll's. If you want to take a stab at debugging this, run |
@parkr: I know for sure so far that this fails when the output directory already exists. If I remove it, it works fine. Are you sure this isn't Jekyll's fault after all?
So nothing fancy in the log... BTW, my gem list
PS. Shouldn't we talk about this stuff in an upstream issue? |
@parkr: I came to the conclusion that listen is to blame. When I revert listen to 2.7.6 EDIT: Damn, still fails some times even with listen 2.7.6. |
@XhmikosR I don't see any problems when I run |
@juthilo: sorry, I don't. I do plan to update to Ruby 2.x at some point though. |
How about we just inform Windows users to use |
So any thoughts? I say we just add the |
for windows users, yep! 👍 |
@parkr Do you know anything about the Ruby versions and/or system architectures affected by the problem? Specifically, if Ruby 2 32bit doesn't exhibit this issue, there's no need to add it to the guide, as it only supports Ruby 2 and I've already confirmed the 64bit version as working. |
I don't. I have never encountered this issue myself, and we get occasional reports of this issue from people with all sorts of OS's & architectures. Might be wise to say "use |
Ok great, will do. Thanks! |
👍 Danke dir! |
😊 |
@XhmikosR I assumed this problem was related to the auto-regeneration dependencies, so I added both Do we need a note in the README or is the general reference to my guide for Windows users sufficient? |
Looks good @juthilo, thanks! |
Update Jekyll to v2.4.0 and rouge to v1.7.2.
Hey I tried to use |
@alexnb98: you do understand you are commenting on a ~4-year old PR? |
/CC @cvrebert @juthilo
Are you aware of any issues that prevent us from updating?