Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jekyll to v2.4.0 and rouge to v1.7.2. #14746

Merged
merged 1 commit into from
Nov 1, 2014
Merged

Update Jekyll to v2.4.0 and rouge to v1.7.2. #14746

merged 1 commit into from
Nov 1, 2014

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Oct 7, 2014

/CC @cvrebert @juthilo

Are you aware of any issues that prevent us from updating?

@XhmikosR XhmikosR added the docs label Oct 7, 2014
@XhmikosR XhmikosR added this to the v3.2.1 milestone Oct 7, 2014
@cvrebert
Copy link
Collaborator

cvrebert commented Oct 7, 2014

I think we had been blocking on github/pages-gem#75 , but that's now been implemented. 😄

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 7, 2014

I think GitHub pages is using 2.4.0 too https://github.com/github/pages-gem/blob/master/lib/github-pages.rb#L10

@hnrch02
Copy link
Collaborator

hnrch02 commented Oct 8, 2014

Yeah, they are running 2.4.0. See https://pages.github.com/versions/.

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 8, 2014

@hnrch02: I'm pretty sure they generate that page from the file I linked above :)

I'm hitting an issue on Windows with 2.4.0; jekyll serve fails if the output directory already exists, "_gh-pages" in our case.

Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation.  All rights reserved.

C:\Users\xmr\Desktop\bootstrap>ruby -v && jekyll -v
ruby 1.9.3p545 (2014-02-24) [i386-mingw32]
jekyll 2.4.0

C:\Users\xmr\Desktop\bootstrap>dir /b
.editorconfig
.gitattributes
.gitignore
.travis.yml
bower.json
CNAME
composer.json
CONTRIBUTING.md
dist
docs
fonts
grunt
Gruntfile.js
js
less
LICENSE
node_modules
package.json
README.md
test-infra
_config.yml

C:\Users\xmr\Desktop\bootstrap>jekyll serve
Configuration file: C:/Users/xmr/Desktop/bootstrap/_config.yml
            Source: docs
       Destination: _gh_pages
      Generating...
                    done.
 Auto-regeneration: enabled for 'docs'
Configuration file: C:/Users/xmr/Desktop/bootstrap/_config.yml
    Server address: http://0.0.0.0:9001//
  Server running... press ctrl-c to stop.
Terminate batch job (Y/N)? y

C:\Users\xmr\Desktop\bootstrap>dir /b
.editorconfig
.gitattributes
.gitignore
.travis.yml
bower.json
CNAME
composer.json
CONTRIBUTING.md
dist
docs
fonts
grunt
Gruntfile.js
js
less
LICENSE
node_modules
package.json
README.md
test-infra
_config.yml
_gh_pages

C:\Users\xmr\Desktop\bootstrap>jekyll serve
Configuration file: C:/Users/xmr/Desktop/bootstrap/_config.yml
            Source: docs
       Destination: _gh_pages
      Generating...
                    done.

C:\Users\xmr\Desktop\bootstrap>

I'll check if this issue is reported upstream...

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 8, 2014

OK, it seems it's jekyll/jekyll#2926, jekyll serve --force-polling seems to work around the issue.

@cvrebert
Copy link
Collaborator

cvrebert commented Oct 8, 2014

Have you added the wdm gem as mentioned on http://jekyllrb.com/docs/windows/ ?

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 8, 2014

Ofc @cvrebert, that's Jekyll 101 :P

@cvrebert
Copy link
Collaborator

cvrebert commented Oct 8, 2014

OK, just covering all the bases. :P

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 8, 2014

@juthilo: maybe you could mention this workaround on your guide? I'm not sure if/when it will be fixed upstream...

@parkr
Copy link

parkr commented Oct 8, 2014

OK, it seems it's jekyll/jekyll#2926, jekyll serve --force-polling seems to work around the issue.

@juthilo Note that it's jekyll serve/build --watch --force_polling with the underscore and it only makes a difference when used in conjunction with --watch. Note that --watch is now enabled by default on serve so jekyll serve --force_polling should work for you.

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 8, 2014

@parkr: you probably meant to CC me I guess :P

So any ideas why this is caused? I will say it again, feel free to CC me before any release (as long as you have a gem published) to do some tests on my Windows machine. It seems things break quite often.

@parkr
Copy link

parkr commented Oct 8, 2014

@parkr: you probably meant to CC me I guess :P

Whoops! Yep. :)

So any ideas why this is caused?

Man, I wish I knew. I know it's on Listen's end (or wdm's end), and not Jekyll's. If you want to take a stab at debugging this, run jekyll serve with the LISTEN_GEM_DEBUGGING environment variable set to 1. It'll print out a bunch of debugging statements about what Listen is doing in the background and might make the issue more clear.

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 8, 2014

@parkr: I know for sure so far that this fails when the output directory already exists. If I remove it, it works fine. Are you sure this isn't Jekyll's fault after all?

@parkr:

Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation.  All rights reserved.

C:\Users\xmr\Desktop\bootstrap>set LISTEN_GEM_DEBUGGING=1

C:\Users\xmr\Desktop\bootstrap>ruby -v && jekyll -v
ruby 1.9.3p545 (2014-02-24) [i386-mingw32]
jekyll 2.4.0

C:\Users\xmr\Desktop\bootstrap>jekyll serve
Configuration file: C:/Users/xmr/Desktop/bootstrap/_config.yml
            Source: docs
       Destination: _gh_pages
      Generating...
                    done.
I, [2014-10-08T22:47:58.510619 #3436]  INFO -- : Celluloid loglevel set to: 1
I, [2014-10-08T22:47:58.626191 #3436]  INFO -- : Record.build(): 0.0330212116241
4551 seconds

C:\Users\xmr\Desktop\bootstrap>

So nothing fancy in the log...

BTW, my gem list

C:\Users\xmr\Desktop>gem list

*** LOCAL GEMS ***

actionmailer (4.1.6)
actionpack (4.1.6, 4.1.5)
actionview (4.1.6, 4.1.5)
activemodel (4.1.6, 4.1.5)
activerecord (4.1.6)
activerecord-sqlserver-adapter (4.1.0)
activeresource (4.0.0)
activesupport (4.1.6, 4.1.5, 3.2.19)
addressable (2.3.6)
arel (5.0.1.20140414130214)
bigdecimal (1.2.5)
blankslate (3.1.3, 2.1.2.4)
builder (3.2.2)
bundler (1.7.3)
celluloid (0.16.0)
classifier-reborn (2.0.1)
coffee-rails (4.0.1)
coffee-script (2.3.0)
coffee-script-source (1.8.0)
colorator (0.1)
cucumber (1.3.17, 1.3.11)
diff-lcs (1.2.5)
docile (1.1.5)
erubis (2.7.0)
execjs (2.2.1)
fast-stemmer (1.0.2)
ffi (1.9.5 x86-mingw32)
gherkin (2.12.2 x86-mingw32)
hike (2.1.3, 1.2.3)
hitimes (1.2.2)
i18n (0.6.11)
io-console (0.4.2)
jekyll (2.4.0)
jekyll-coffeescript (1.0.1)
jekyll-gist (1.1.0)
jekyll-paginate (1.0.0)
jekyll-sass-converter (1.2.1)
jekyll-watch (1.1.1)
jekyll_test_plugin (0.1.0)
jekyll_test_plugin_malicious (0.1.0)
journey (1.0.4)
jquery-rails (3.1.2)
json (1.8.1)
kramdown (1.4.2)
launchy (2.4.2)
liquid (2.6.1)
listen (2.7.11)
mail (2.6.1)
maruku (0.7.2)
mercenary (0.3.4)
mime-types (2.4.1, 1.25.1)
minitest (5.4.2)
multi_json (1.10.1)
multi_test (0.1.1)
parslet (1.6.1, 1.5.0)
pg (0.17.1 x86-mingw32)
polyglot (0.3.5)
posix-spawn (0.3.9)
pygments.rb (0.6.0)
rack (1.5.2)
rack-cache (1.2)
rack-ssl (1.4.1)
rack-test (0.6.2)
rails (4.1.6)
rails-observers (0.1.2)
railties (4.1.6)
rake (10.3.2, 0.9.2.2)
rb-fsevent (0.9.4)
rb-inotify (0.9.5)
rb-readline (0.5.1)
rdiscount (2.1.7.1, 1.6.8)
rdoc (4.1.2, 3.12.2)
redcarpet (3.1.2)
RedCloth (4.2.9 x86-mingw32)
redgreen (1.2.2)
rouge (1.7.2)
rr (1.1.2)
rubygems-update (2.4.2)
rubyzip (1.1.6)
safe_yaml (1.0.4)
sass (3.4.5, 3.2.19)
sass-rails (4.0.3)
shoulda (3.5.0)
shoulda-context (1.2.1)
shoulda-matchers (2.7.0)
simplecov (0.9.1)
simplecov-gem-adapter (1.0.1)
simplecov-html (0.8.0)
sprockets (2.12.2, 2.11.0)
sprockets-rails (2.1.4)
sqlite3 (1.3.9 x86-mingw32)
sqlite3-ruby (1.3.3)
thor (0.19.1)
thread_safe (0.3.4)
tilt (2.0.1, 1.4.1)
timers (4.0.1)
tiny_tds (0.6.2 x86-mingw32)
toml (0.1.1)
treetop (1.5.3)
tzinfo (1.2.2)
wdm (0.1.0)
yajl-ruby (1.2.1, 1.1.0 x86-mingw32)

PS. Shouldn't we talk about this stuff in an upstream issue?

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 8, 2014

@parkr: I came to the conclusion that listen is to blame. When I revert listen to 2.7.6 jekyll serve works fine.

EDIT: Damn, still fails some times even with listen 2.7.6.

@XhmikosR XhmikosR removed this from the v3.2.1 milestone Oct 13, 2014
@juthilo
Copy link
Collaborator

juthilo commented Oct 14, 2014

@XhmikosR I don't see any problems when I run jekyll serve in my local Bootstrap folder. I'm using Ruby 2.0.0 on a 64-bit system and you seem to be using Ruby 1.9.3 on a 32-bit system. Do you have any other Windows machines or Ruby setups to test on?

@XhmikosR
Copy link
Member Author

@juthilo: sorry, I don't. I do plan to update to Ruby 2.x at some point though.

@XhmikosR
Copy link
Member Author

How about we just inform Windows users to use jekyll serve --force_polling and go ahead with this?

@XhmikosR XhmikosR modified the milestone: v3.3.1 Oct 29, 2014
@XhmikosR
Copy link
Member Author

So any thoughts? I say we just add the --force_polling workaround in README.md and/or in @juthilo's guide and go ahead with this.

@parkr
Copy link

parkr commented Oct 31, 2014

I say we just add the --force_polling workaround in README.md

for windows users, yep! 👍

@juthilo
Copy link
Collaborator

juthilo commented Oct 31, 2014

@parkr Do you know anything about the Ruby versions and/or system architectures affected by the problem? Specifically, if Ruby 2 32bit doesn't exhibit this issue, there's no need to add it to the guide, as it only supports Ruby 2 and I've already confirmed the 64bit version as working.

@parkr
Copy link

parkr commented Oct 31, 2014

@parkr Do you know anything about the Ruby versions and/or system architectures affected by the problem? Specifically, if Ruby 2 32bit doesn't exhibit this issue, there's no need to add it to the guide, as it only supports Ruby 2 and I've already confirmed the 64bit version as working.

I don't. I have never encountered this issue myself, and we get occasional reports of this issue from people with all sorts of OS's & architectures. Might be wise to say "use --force_polling if the site isn't regenerating on each save," and leave the OS/arch out of it.

@juthilo
Copy link
Collaborator

juthilo commented Oct 31, 2014

Ok great, will do. Thanks!

@parkr
Copy link

parkr commented Oct 31, 2014

Ok great, will do. Thanks!

👍 Danke dir!

@juthilo
Copy link
Collaborator

juthilo commented Oct 31, 2014

😊

juthilo added a commit to juthilo/run-jekyll-on-windows that referenced this pull request Oct 31, 2014
@juthilo
Copy link
Collaborator

juthilo commented Oct 31, 2014

@XhmikosR I assumed this problem was related to the auto-regeneration dependencies, so I added both jekyll build --watch and jekyll serve to the note in my guide. Please tell me if that's not correct and I'll update it.

Do we need a note in the README or is the general reference to my guide for Windows users sufficient?

@XhmikosR
Copy link
Member Author

Looks good @juthilo, thanks!

XhmikosR added a commit that referenced this pull request Nov 1, 2014
Update Jekyll to v2.4.0 and rouge to v1.7.2.
@XhmikosR XhmikosR merged commit 7d8bacb into master Nov 1, 2014
@XhmikosR XhmikosR deleted the gems-bump branch November 1, 2014 08:02
@alexnb98
Copy link

alexnb98 commented Apr 21, 2018

Hey I tried to use jekyll serve jekyll build --watch with and without --force_pulling and it didnt worked. It turned out I didnt had bundler installed. So I tipped in the command line gem install bundle then bundle install and now it worked fine with jekyll serve. Just type bundle -v to see if you have it installed.
I wanted to share it, it might help someone.

@XhmikosR
Copy link
Member Author

@alexnb98: you do understand you are commenting on a ~4-year old PR?

@twbs twbs locked as resolved and limited conversation to collaborators Apr 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants