Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertically center .icon-prev and .icon-next in carousel #15244

Merged
merged 1 commit into from Nov 30, 2014

Conversation

@zalog
Copy link
Contributor

commented Nov 27, 2014

Center .icon-prev and .icon-next the same way .glyphicon icon are.
And this is the html markup:

<a class="left carousel-control" href="#carousel-main-menu" role="button" data-slide="prev">
    <span class="icon-prev" aria-hidden="true"></span>
</a>
Center .icon-prev and .icon-next
Center .icon-prev and .icon-next the same way .glyphicon icon are.
And this is the html markup:
<a class="left carousel-control" href="#carousel-main-menu" role="button" data-slide="prev">
<span class="icon-prev" aria-hidden="true"></span>
</a>

@cvrebert cvrebert changed the title Center .icon-prev and .icon-next Center .icon-prev and .icon-next in carousel Nov 27, 2014

@cvrebert cvrebert added the css label Nov 27, 2014

@mdo

This comment has been minimized.

Copy link
Member

commented Nov 29, 2014

Have a before/after example for this by chance?

@zalog

This comment has been minimized.

Copy link
Contributor Author

commented Nov 29, 2014

Sure!
before-after
I hope it helps.

@mdo

This comment has been minimized.

Copy link
Member

commented Nov 30, 2014

For full context, what browser and version are those screenshots from? I'll need to cross browser check the other ones if you haven't already done so as there are occasional font alignment inconsistencies.

@mdo mdo added this to the v3.3.2 milestone Nov 30, 2014

mdo added a commit that referenced this pull request Nov 30, 2014
Merge pull request #15244 from zalog/patch-2
Center .icon-prev and .icon-next in carousel

@mdo mdo merged commit ced63b0 into twbs:master Nov 30, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@juthilo juthilo referenced this pull request Nov 30, 2014
@zalog

This comment has been minimized.

Copy link
Contributor Author

commented Dec 2, 2014

Thanks!
Here a simulation, just in case :)
http://www.bootply.com/IZ6E3eu04r
line-height it's commented

@cvrebert cvrebert changed the title Center .icon-prev and .icon-next in carousel Vertically center .icon-prev and .icon-next in carousel Dec 8, 2014

@zalog zalog deleted the zalog:patch-2 branch Feb 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.