btn-lg is smaller than input-lg

[fassetar]

In Chrome, Safari, and Firefox (not IE10+) btn-lg is a pixel off and should be 46px but instead its 45px. Here is some code that I'm working with. What I've done in my projects is just add a height:46px to btn-lg but I think a better solution is to just change the @line-height-large to 1.34 instead of 1.33.

[mdo]

Without testing this within every supported browser (and all their supported versions), we can't merge this. I know there have been problems with this in the past, but I'm unsure where we landed off the top of the head.

Do you have the ability and time to give it a go by chance?

[fassetar]

Ya, not a problem. I have plenty of time, I'm not familiar with sauce labs but I can pick it up.

[twbs-savage]

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: ec7bfd6
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/45717175

(Please note that this is a fully automated comment.)

[twbs-savage]

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 2c2a8d6
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/46883953

(Please note that this is a fully automated comment.)

[twbs-savage]

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 73c1f2b
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/46885995

(Please note that this is a fully automated comment.)

[mdo]

Trailing whitespace here

[mdo]

I really don't want to set the height of buttons, which is why I haven't pursued this much. I'll check in on the problem again when I can.

[fassetar]

I agree, I will play around some more but here are my notes.

[mdo]

Closing as we aren't going to be setting the height.