Show active buttons when form disabled #16804

Merged
merged 1 commit into from Aug 5, 2015

Projects

None yet

5 participants

@edwinlin1987
Contributor

Resolves #16767.

Button-variant mixins were overwriting the colors of active buttons when the forms were disabled. With the changes, the buttons are still noticeably disabled, but the active button is still faintly identifiable.

Original Issue:
http://codepen.io/seyfert/pen/PqRwXR?editors=101

Compiled Solution Code:
http://codepen.io/edwinlin1987/pen/XbqPJY

@cvrebert cvrebert added the css label Jul 11, 2015
@mdo mdo added this to the v3.3.6 milestone Aug 5, 2015
@mdo
Member
mdo commented Aug 5, 2015

Sounds fine to me!

@mdo mdo merged commit 70ab634 into twbs:master Aug 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bcameron

Hi Edwin,
I'm not sure if I'm witnessing a bug or not, but I'm experiencing a regression with my upgrade from 3.2 to 3.3.6.

Basically, I have a .form-control.btn.btn-danger[disabled] and in 3.2 it shows its default color(shaded/darkened red) but in 3.3.6 the background disappears (only if the button is a .form-control also)

My understanding is:

.form-control resets the background color (to grey).

In bootstrap 3.2 .btn-danger[disabled] redeclares the background color property which gives the correct results.

In bootstrap 3.3.6 .btn-danger[disabled] is missing. I believe this is due to the removal of the '&' (call it a 'pass through') of line 45(from version 3.2) above.

Now the question remains if this behavior conflicts with your intentions for this commit or not? And if, in general, this layered redeclaration of background colors indicates a deeper architectural issue but I'm not familiar with the code enough to have an opinion on that.

Have you any thoughts, (it's easy to work around this anyway!)
Thanks,
Brian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment