Update dependecies. #17436
Update dependecies. #17436
Conversation
XhmikosR
force-pushed
the
v4-dev-xmr-deps
branch
from
70ac75a
to
d1bd172
Compare
| @@ -28,7 +28,7 @@ | |||
| "requireSpaceAfterLineComment": true, | |||
| "requireSpaceBeforeBinaryOperators": ["+", "-", "/", "*", "=", "==", "===", "!=", "!==", ">", "<", ">=", "<="], | |||
| "requireSpaceBetweenArguments": true, | |||
| "requireSpacesInAnonymousFunctionExpression": { "beforeOpeningCurlyBrace": true, "beforeOpeningRoundBrace": true }, | |||
There was a problem hiding this comment.
Was the rule removed from JSCS itself, or do we not currently comply with it?
There was a problem hiding this comment.
It just fails but I'm not sure if it's a regression or intentional.
On Sep 2, 2015 10:09, "Chris Rebert" notifications@github.com wrote:
In js/.jscsrc
#17436 (comment):@@ -28,7 +28,7 @@
"requireSpaceAfterLineComment": true,
"requireSpaceBeforeBinaryOperators": ["+", "-", "/", "*", "=", "==", "===", "!=", "!==", ">", "<", ">=", "<="],
"requireSpaceBetweenArguments": true,
- "requireSpacesInAnonymousFunctionExpression": { "beforeOpeningCurlyBrace": true, "beforeOpeningRoundBrace": true },
Was the rule removed from JSCS itself, or do we not currently comply with
it?—
Reply to this email directly or view it on GitHub
https://github.com/twbs/bootstrap/pull/17436/files#r38503896.
XhmikosR
force-pushed
the
v4-dev-xmr-deps
branch
from
d1bd172
to
b439156
Compare
XhmikosR
force-pushed
the
v4-dev-xmr-deps
branch
from
b439156
to
b713f6b
Compare
|
bump |
|
Perhaps we could punt JSCS to another PR/issue for further investigation, and merge everything else? |
XhmikosR
force-pushed
the
v4-dev-xmr-deps
branch
from
b713f6b
to
83d5517
Compare
|
I can split it if you think it's better, sure. |
XhmikosR
force-pushed
the
v4-dev-xmr-deps
branch
from
83d5517
to
f0840c8
Compare
|
Done. |
|
|
as soon as Travis passes.
/CC @cvrebert