v4: Nav cleanup #18783

Merged
merged 8 commits into from Jan 6, 2016

Projects

None yet

1 participant

@mdo
Member
mdo commented Jan 6, 2016

Encouraged by #18630.

We had some styles for our nav components that weren't being set by variables. We also had some variable that weren't being used (or were being used improperly). This fixes those variables, adds a handful of new ones, consolidates some styles, and updates the docs for more consistent examples.

mdo added some commits Jan 6, 2016
@mdo mdo Nav docs updates
- More consistent states and labels in nav examples
- Add stacked pills example for with <nav> element
9c19dc9
@mdo mdo Add $nav-item-inline-spacer variable
So folks can customize the distance between nav links in inline navs.
030ab62
@mdo mdo Add $nav-disabled-link-hover-bg variable 7668a66
@mdo mdo Revamp tabbed nav border variables
- Add new $nav-tabs-border-width for the bottom border on the .nav-tabs
parent class
- Use that new variable for the negative margin on nav-items within it
for consistent customization
- Drop the $nav-tabs-link-border-width for the new variable so it’s all
tied together
93dda63
@mdo mdo Regroup nav variables 7da2e12
@mdo mdo Spacing y'all 774a2ed
@mdo mdo New $nav-pills-active-link-* variables
- Renames old and unused $nav-pills-active-link-hover-* for
$nav-pills-active-link-* ones
- Puts those vars to use in place of defaults $component-* vars on nav
pills
fac0c31
@mdo mdo Consolidate nav-tab dropdown styles with nav-tab styles
- Moves styles up the document a bit to nest them
- Drops the static 1px for $navbar-tabs-border-width so once again it’s
all tied together should folks customize that
c847279
@mdo mdo added docs css v4 labels Jan 6, 2016
@mdo mdo added this to the v4.0.0-alpha.3 milestone Jan 6, 2016
@mdo mdo referenced this pull request Jan 6, 2016
Closed

nav links inconsistencies #18630

@mdo mdo merged commit 416efb8 into v4-dev Jan 6, 2016

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
hound No violations found. Woof!
@mdo mdo deleted the v4-nav-cleanup branch Jan 6, 2016
@mdo mdo referenced this pull request Jan 6, 2016
Closed

v4 alpha 3 ship list #18480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment