New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Nav cleanup #18783

Merged
merged 8 commits into from Jan 6, 2016

Conversation

Projects
None yet
1 participant
@mdo
Member

mdo commented Jan 6, 2016

Encouraged by #18630.

We had some styles for our nav components that weren't being set by variables. We also had some variable that weren't being used (or were being used improperly). This fixes those variables, adds a handful of new ones, consolidates some styles, and updates the docs for more consistent examples.

mdo added some commits Jan 6, 2016

Nav docs updates
- More consistent states and labels in nav examples
- Add stacked pills example for with <nav> element
Add $nav-item-inline-spacer variable
So folks can customize the distance between nav links in inline navs.
Revamp tabbed nav border variables
- Add new $nav-tabs-border-width for the bottom border on the .nav-tabs
parent class
- Use that new variable for the negative margin on nav-items within it
for consistent customization
- Drop the $nav-tabs-link-border-width for the new variable so it’s all
tied together
New $nav-pills-active-link-* variables
- Renames old and unused $nav-pills-active-link-hover-* for
$nav-pills-active-link-* ones
- Puts those vars to use in place of defaults $component-* vars on nav
pills
Consolidate nav-tab dropdown styles with nav-tab styles
- Moves styles up the document a bit to nest them
- Drops the static 1px for $navbar-tabs-border-width so once again it’s
all tied together should folks customize that

@mdo mdo added docs css v4 labels Jan 6, 2016

@mdo mdo added this to the v4.0.0-alpha.3 milestone Jan 6, 2016

@mdo mdo referenced this pull request Jan 6, 2016

Closed

nav links inconsistencies #18630

mdo added a commit that referenced this pull request Jan 6, 2016

@mdo mdo merged commit 416efb8 into v4-dev Jan 6, 2016

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
hound No violations found. Woof!

@mdo mdo deleted the v4-nav-cleanup branch Jan 6, 2016

@mdo mdo referenced this pull request Jan 6, 2016

Closed

v4 alpha 3 ship list #18480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment