refactor pagination in accordance with the Navs #18838

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@bassjobsen
Contributor

bassjobsen commented Jan 11, 2016

No description provided.

bassjobsen added some commits Jan 11, 2016

refactoring pagination
Apply states (active, disabled) on the `.page-link` instead of the `.page-item` to create more flexible CSS classes ( 	in accordance with the Navs).
A "reset" is required due to the `:first-child` and `:last-child` selectors. If you do not like the "reset", consider introducing a first and last state which should enable you to write:

    .page-item.first .page-link,
    .page-link.first {
      margin-left: 0;
      @include border-left-radius($border-radius);
    }
    .page-item.last .page-link,
    .page-link.last {
      @include border-right-radius($border-radius);
    }

@cvrebert cvrebert added css v4 labels Jan 11, 2016

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Jan 16, 2017

Member

This was nullified by Alpha 6. Thanks though!

Member

mdo commented Jan 16, 2017

This was nullified by Alpha 6. Thanks though!

@mdo mdo closed this Jan 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment