v4: Grid redux #19099

Merged
merged 34 commits into from Feb 6, 2016

Projects

None yet

6 participants

@mdo
Member
mdo commented Feb 6, 2016

Addresses a handful of grid changes:

  • 17119: Stubs out docs for flexbox grid.

  • 17131: Adds auto layout for flexbox grid columns (to mixins and predefined classes) with the addition of .col-{breakpoint classes. For example, use .col-xs to create as many grid columns as you'd like from xs and up.

  • 17261, #17603: Adds a new .col base class for grid columns and Changes the responsive grid modifier naming scheme from .col-{breakpoint}-{modifier}-{size} to .{modifier}-{breakpoint}-{size} for simpler grid classes. For example, instead of .col-md-3.col-md-push-9 it's col-md-3.push-md-9. Also updates all examples to new markup.

  • 17512, #17514: Overhauls the grid mixins to merge make-col and make-col-span into a single make-col mixin, thereby ensuring mixins and predefined classes utilize the same float/flex behaviors.

  • 17593: Adds basic grid migration documentation, including mention of flexbox support, flexbox utils, and variables/maps changes.

  • 18024 , #18164: Horizontal flexbox alignment utilities added.

  • 18691: Documents flexbox vertical alignment utilities.

  • 18785: Cherry-picks the changes to rename our flexbox grid utilities to global flexbox utilities.

Todo:

  • Document flexbox utilities
@mdo mdo added css v4 labels Feb 6, 2016
@mdo mdo added this to the v4.0.0-alpha.3 milestone Feb 6, 2016
mdo added some commits Feb 6, 2016
@mdo mdo Conditionally include the flex utils in the import stack and reduce t…
…o a single query
044716e
@mdo mdo rename .flex-all-* to .flex-items-* to match flexbox nomenclature 0de7321
@mdo mdo Move the conditional statement back to the file because nested import…
…s aren't supported in Sass
7b7cf22
@mdo mdo Add vertical alignment docs for flexbox grid
9a519bb
@mdo mdo Tweak docs example CSS for flexbox grid cols
44bcaff
mdo added some commits Feb 6, 2016
@mdo mdo more accurate comments 82b98e7
@mdo mdo rename vertical align flex utils to middle to avoid clash with horizo…
…ntal center
5e41887
@mdo mdo add horizontal flex utils 9e32140
@mdo mdo document horizontal flex utils, update the classes for the middle ver…
…tical ones
2a678d4
@mdo mdo simpler, more specific docs example css
94999c9
@mdo
Member
mdo commented Feb 6, 2016

Most of this is done, including feedback from @cvrebert and @glebm, but I think I fucked up haha.

Need to revisit this a bit more yet—responsive is broken right now. I think I need to redo the main grid-framework mixins to generate something more akin to the Bootstrap 3 and http://flexboxgrid.com approaches. That is to say, nuke the base class and list out all the classes with a specific .col-{breakpoint} class for auto-width flexbox instead.

Going to need to noodle on that for awhile if no one jumps in to help.

@karlhorky

Looks like this addresses #18088 as well. I've closed it.

@mdo mdo flip things around again, no more base class, try out some new stuff …
…to keep responsive flex grid working
414997b
@houndci-bot houndci-bot commented on an outdated diff Feb 6, 2016
scss/mixins/_grid-framework.scss
@include media-breakpoint-up($breakpoint, $breakpoints) {
// Work around cross-media @extend (https://github.com/sass/sass/issues/1050)
- %grid-column-float-#{$breakpoint} {
- float: left;
+ // %grid-column-float-#{$breakpoint} {
+ // float: left;
+ // }
+ @if $enable-flex {
+ .col-#{$breakpoint} {
+ @include make-col($gutter);
+ flex-basis: 0;
@houndci-bot
houndci-bot Feb 6, 2016

Properties should be ordered max-width, flex-basis, flex-grow

@houndci-bot houndci-bot commented on an outdated diff Feb 6, 2016
scss/_grid.scss
- }
-
- // Alignment for every column in row
-
- @each $breakpoint in map-keys($grid-breakpoints) {
- @include media-breakpoint-up($breakpoint) {
- .row-#{$breakpoint}-top { align-items: flex-start; }
- .row-#{$breakpoint}-center { align-items: center; }
- .row-#{$breakpoint}-bottom { align-items: flex-end; }
- }
+ [class^="col"] {
+ position: relative;
+ min-height: 1px;
+ padding-right: ($grid-gutter-width / 2);
+ padding-left: ($grid-gutter-width / 2);
+ //
@houndci-bot
houndci-bot Feb 6, 2016

Line contains trailing whitespace

@mdo mdo More grid updates
- Flexbox responsive behavior fixed with specific .col-{breakpoint} classes now added
- Dropped the make-col mixin in favor of a column-basics placeholder that we can extend across our grid infrastructure
- Updated docs to use required .col-xs-12 (as a safeguard for when folks enable flexbox mode--this isn't necessary in default grid mode)
- Update flexbox grid docs to include responsive docs, tweak some other bits too
95f34be
@houndci-bot houndci-bot commented on an outdated diff Feb 6, 2016
scss/mixins/_grid.scss
min-height: 1px;
- padding-left: ($gutter / 2);
- padding-right: ($gutter / 2);
+ padding-left: ($grid-gutter-width / 2);
@houndci-bot
houndci-bot Feb 6, 2016

Properties should be ordered position, min-height, padding-right, padding-left

@houndci-bot
houndci-bot Feb 6, 2016

Properties should be ordered position, min-height, padding-right, padding-left

@houndci-bot houndci-bot commented on an outdated diff Feb 6, 2016
scss/mixins/_grid-framework.scss
@include make-col-modifier($modifier, $i, $columns)
}
}
}
+
@houndci-bot
houndci-bot Feb 6, 2016

Line contains trailing whitespace

@houndci-bot
houndci-bot Feb 6, 2016

Line contains trailing whitespace

@houndci-bot houndci-bot commented on an outdated diff Feb 6, 2016
scss/mixins/_grid-framework.scss
@include media-breakpoint-up($breakpoint, $breakpoints) {
- // Work around cross-media @extend (https://github.com/sass/sass/issues/1050)
- %grid-column-float-#{$breakpoint} {
- float: left;
+ @if $enable-flex {
+ .col-#{$breakpoint} {
+ @extend column-basics; // Relative position, min-height, and horizontal padding
+ flex-basis: 0;
@houndci-bot
houndci-bot Feb 6, 2016

Properties should be ordered max-width, flex-basis, flex-grow

@houndci-bot
houndci-bot Feb 6, 2016

Properties should be ordered max-width, flex-basis, flex-grow

mdo added some commits Feb 6, 2016
@mdo mdo property order
4ab7c93
@mdo mdo property order and white space
50e854a
@mdo mdo Ugh, Sass doesn't do extends across media, so we can't use placeholde…
…r here
15018a6
@houndci-bot houndci-bot commented on an outdated diff Feb 6, 2016
scss/mixins/_grid-framework.scss
@include media-breakpoint-up($breakpoint, $breakpoints) {
- // Work around cross-media @extend (https://github.com/sass/sass/issues/1050)
- %grid-column-float-#{$breakpoint} {
- float: left;
+ @if $enable-flex {
+ .col-#{$breakpoint} {
+ position: relative;
+ max-width: 100%;
+ min-height: 1px;
+ flex-basis: 0;
@houndci-bot
houndci-bot Feb 6, 2016

Properties should be ordered position, max-width, min-height, padding-right, padding-left, flex-basis, flex-grow

mdo added some commits Feb 6, 2016
@mdo mdo disable linter d043fe4
@mdo mdo Merge branch 'v4-dev' into v4-grid-redux f127bc6
@mdo mdo Merge branch 'v4-dev' into v4-grid-redux
8d46a95
@houndci-bot houndci-bot commented on an outdated diff Feb 6, 2016
scss/utilities/_flex.scss
+ .flex-items-#{$breakpoint}-bottom { align-items: flex-end; }
+ }
+
+ // Alignment per item
+ @include media-breakpoint-up($breakpoint) {
+ .flex-#{$breakpoint}-top { align-self: flex-start; }
+ .flex-#{$breakpoint}-middle { align-self: center; }
+ .flex-#{$breakpoint}-bottom { align-self: flex-end; }
+ }
+
+ // Horizontal alignment of item
+ @include media-breakpoint-up($breakpoint) {
+ .flex-items-#{$breakpoint}-left { justify-content: flex-start; }
+ .flex-items-#{$breakpoint}-center { justify-content: center; }
+ .flex-items-#{$breakpoint}-right { justify-content: flex-end; }
+ .flex-items-#{$breakpoint}-around { justify-content: space-around; }
@houndci-bot
houndci-bot Feb 6, 2016

Opening curly brace { should be preceded by one space

@houndci-bot houndci-bot commented on an outdated diff Feb 6, 2016
scss/utilities/_flex.scss
+ .flex-items-#{$breakpoint}-middle { align-items: center; }
+ .flex-items-#{$breakpoint}-bottom { align-items: flex-end; }
+ }
+
+ // Alignment per item
+ @include media-breakpoint-up($breakpoint) {
+ .flex-#{$breakpoint}-top { align-self: flex-start; }
+ .flex-#{$breakpoint}-middle { align-self: center; }
+ .flex-#{$breakpoint}-bottom { align-self: flex-end; }
+ }
+
+ // Horizontal alignment of item
+ @include media-breakpoint-up($breakpoint) {
+ .flex-items-#{$breakpoint}-left { justify-content: flex-start; }
+ .flex-items-#{$breakpoint}-center { justify-content: center; }
+ .flex-items-#{$breakpoint}-right { justify-content: flex-end; }
@houndci-bot
houndci-bot Feb 6, 2016

Opening curly brace { should be preceded by one space

@houndci-bot houndci-bot commented on an outdated diff Feb 6, 2016
scss/utilities/_flex.scss
+ .flex-items-#{$breakpoint}-top { align-items: flex-start; }
+ .flex-items-#{$breakpoint}-middle { align-items: center; }
+ .flex-items-#{$breakpoint}-bottom { align-items: flex-end; }
+ }
+
+ // Alignment per item
+ @include media-breakpoint-up($breakpoint) {
+ .flex-#{$breakpoint}-top { align-self: flex-start; }
+ .flex-#{$breakpoint}-middle { align-self: center; }
+ .flex-#{$breakpoint}-bottom { align-self: flex-end; }
+ }
+
+ // Horizontal alignment of item
+ @include media-breakpoint-up($breakpoint) {
+ .flex-items-#{$breakpoint}-left { justify-content: flex-start; }
+ .flex-items-#{$breakpoint}-center { justify-content: center; }
@houndci-bot
houndci-bot Feb 6, 2016

Opening curly brace { should be preceded by one space

@houndci-bot houndci-bot commented on an outdated diff Feb 6, 2016
scss/utilities/_flex.scss
+ @include media-breakpoint-up($breakpoint) {
+ .flex-items-#{$breakpoint}-top { align-items: flex-start; }
+ .flex-items-#{$breakpoint}-middle { align-items: center; }
+ .flex-items-#{$breakpoint}-bottom { align-items: flex-end; }
+ }
+
+ // Alignment per item
+ @include media-breakpoint-up($breakpoint) {
+ .flex-#{$breakpoint}-top { align-self: flex-start; }
+ .flex-#{$breakpoint}-middle { align-self: center; }
+ .flex-#{$breakpoint}-bottom { align-self: flex-end; }
+ }
+
+ // Horizontal alignment of item
+ @include media-breakpoint-up($breakpoint) {
+ .flex-items-#{$breakpoint}-left { justify-content: flex-start; }
@houndci-bot
houndci-bot Feb 6, 2016

Opening curly brace { should be preceded by one space

@houndci-bot houndci-bot commented on an outdated diff Feb 6, 2016
scss/utilities/_flex.scss
+ // Flex column reordering
+ @include media-breakpoint-up($breakpoint) {
+ .flex-#{$breakpoint}-first { order: -1; }
+ .flex-#{$breakpoint}-last { order: 1; }
+ }
+
+ // Alignment for every item
+ @include media-breakpoint-up($breakpoint) {
+ .flex-items-#{$breakpoint}-top { align-items: flex-start; }
+ .flex-items-#{$breakpoint}-middle { align-items: center; }
+ .flex-items-#{$breakpoint}-bottom { align-items: flex-end; }
+ }
+
+ // Alignment per item
+ @include media-breakpoint-up($breakpoint) {
+ .flex-#{$breakpoint}-top { align-self: flex-start; }
@houndci-bot
houndci-bot Feb 6, 2016

Opening curly brace { should be preceded by one space

@houndci-bot houndci-bot commented on an outdated diff Feb 6, 2016
scss/utilities/_flex.scss
@@ -0,0 +1,36 @@
+// Flex variation
+//
+// Custom styles for additional flex alignment options.
+
+@if $enable-flex and $enable-grid-classes {
+ @each $breakpoint in map-keys($grid-breakpoints) {
+ // Flex column reordering
+ @include media-breakpoint-up($breakpoint) {
+ .flex-#{$breakpoint}-first { order: -1; }
+ .flex-#{$breakpoint}-last { order: 1; }
+ }
+
+ // Alignment for every item
+ @include media-breakpoint-up($breakpoint) {
+ .flex-items-#{$breakpoint}-top { align-items: flex-start; }
@houndci-bot
houndci-bot Feb 6, 2016

Opening curly brace { should be preceded by one space

@houndci-bot houndci-bot commented on an outdated diff Feb 6, 2016
scss/utilities/_flex.scss
@@ -0,0 +1,36 @@
+// Flex variation
+//
+// Custom styles for additional flex alignment options.
+
+@if $enable-flex and $enable-grid-classes {
+ @each $breakpoint in map-keys($grid-breakpoints) {
+ // Flex column reordering
+ @include media-breakpoint-up($breakpoint) {
+ .flex-#{$breakpoint}-first { order: -1; }
+ .flex-#{$breakpoint}-last { order: 1; }
@houndci-bot
houndci-bot Feb 6, 2016

Opening curly brace { should be preceded by one space

@houndci-bot houndci-bot commented on an outdated diff Feb 6, 2016
scss/mixins/_grid-framework.scss
@include media-breakpoint-up($breakpoint, $breakpoints) {
- // Work around cross-media @extend (https://github.com/sass/sass/issues/1050)
- %grid-column-float-#{$breakpoint} {
- float: left;
+ @if $enable-flex {
+ .col-#{$breakpoint} {
+ position: relative;
+ max-width: 100%;
@houndci-bot
houndci-bot Feb 6, 2016

Properties should be ordered position, flex-basis, flex-grow, max-width, min-height, padding-right, padding-left

@mdo mdo linting
3743f27
mdo added some commits Feb 6, 2016
@mdo mdo use px in grid col padding since we're using px everywhere else for them 414ae3a
@mdo mdo formatting 7114e94
@mdo mdo update grid vars docs bc45add
@mdo mdo document how to customize grid tiers fb4f5f0
@mdo mdo document migration for grid system /cc #17593
ce81dd8
@mdo mdo mention media query changes
844a180
@mdo mdo Merge branch 'v4-dev' into v4-grid-redux
fffaaed
@mdo mdo merged commit 3b38801 into v4-dev Feb 6, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
hound 1 violation found.
@mdo mdo deleted the v4-grid-redux branch Feb 6, 2016
@mdo mdo added a commit that referenced this pull request Feb 7, 2016
@mdo mdo Follow up to #19099: Correct grid gutter value 9ca44d2
@cvrebert
Member

<3<3

@cvrebert

@mdo But it's not horizontal if someone sets flex-direction: column..

@mdo mdo added a commit that referenced this pull request Feb 17, 2016
@mdo mdo fixes #19148 as follow up to #19099: ensure local mixin variable is u…
…sed for in make-grid-columns mixin
4043510
@torbjoernk torbjoernk added a commit to torbjoernk/bootstrap that referenced this pull request Feb 17, 2016
@torbjoernk torbjoernk Merge branch 'v4-dev' into sites/jlesc-pint
* v4-dev:
  Extract $navbar-brand-padding-y variable
  Add $card-columns-sm-up-column-gap variable
  Add $list-group-item-padding-{x,y} variables
  _tags.scss: Updated comments to reflect name change
  Extract $code-padding-{x,y} variables
  Extract $code-font-size variable
  Add $figure-caption-font-size variable
  Extract $dropdown-item-padding-x variable
  Extract $carousel-control-sm-up-size variable
  grunt
  Fixes #19142 (follow-up to #18771): Restore cursor: pointer to custom radio/checkbox components
  update migration docs
  grunt
  grunt
  fixes #19148 as follow up to #19099: ensure local mixin variable is used for  in make-grid-columns mixin
  grunt
  Visual/manual test for checkbox/radio button kbd behavior
  Fix typos in plural tag names
  Focus (visually hidden) input radio/checkbox
  js/tests/index.html: Replace jQuery event alias methods with functions that throw explanatory errors, instead of with undefined
  CONTRIBUTING: Document restriction regarding jQuery event alias methods
  Change comment to clarify that $grid-breakpoints are minimum widths for each breakpoint
  Introduce $mark-bg variable so that <mark>'s background-color can be customized independently of $state-warning-bg
  Extract $dropdown-min-width variable
  Add $label-pill-border-radius variable
  Add $label-font-size variable in the name of not hardcoding values
  Extract $label-pill-padding-x variable
  Extract $label-padding-{x,y} variables
  Add $small-font-size variable
  Add $mark-padding variable
  Extract $modal-content-border-width variable
  Extract $modal-{header,footer}-border-width variables
  Extract $modal-dialog-sm-up-margin-y variable
  Extract new $modal-dialog-margin variable
  Fix docs for new naming of .btn-outline
  grunt
  Add extra styles for focused/hovered active outline buttons
  grunt
  Updated label to tag in list-group example
  Rename .label class to .tag
  Remove http://bugzil.la/1060131 from Wall of Browser Bugs
  Remove http://bugzil.la/975632 from Wall of Browser Bugs
  Remove unused .csscomb.json
  clearer copy
  grunt
  linting follow up to #19140
  fixes #18940: use specific border properties when changing the corners of list groups in cards to avoid overriding combo first-/last-child items
  Alternate fix to #17965: Updates to use the new class name and adds some basic docs for custom checkbox/radio validation
  bundle update
  Fixes #18949: Remove extra margin overrides for buttons in .modal-footer
  grunt
  Move to a translucent input border with background-clip: padding-box for improved blending across different background-colors
  clarify, fix margin
  Revert "https://webkit.org/b/138201 no longer repros"
  Flex utility classes shouldn't depend on $enable-grid-classes
  Grid docs: Remove !default from SCSS snippets
  Migration docs: Mention $grid-breakpoints and $container-max-widths by name
  Fixes+tweaks to native font stack docs
  _forms.scss: Use division instead of fractional multiplication
  _forms.scss: Remove extra trailing 0 in fractional number
  Fix apparent typo in b8ff763
  Only caption 1st set of progress bar examples
  grunt
  add example of multiple add-ons to docs
  grunt
  Put that new var to use to match form group addons to form controls
  updated button/form-control padding and line-height
  Remove line-height from the button size mixin too
  Remove commented out height on large/small inputs
  Remove specific line-heights from large/small inputs as well
  Remove line-height from button mixin calls
  grunt dist docs
  _forms.scss: Remove extra url()s in commented-out code
  docs/components/forms.md: Fix typo: non => none
  https://webkit.org/b/138201 no longer repros
  Docs: Add captions above progress bars; refs #17264
  Fix CSS3 :not() selector
  Fix bad localhost link in Typography docs
  Docs: Add "Horizontal centering" subheading for .m-x-auto
  Assert that $grid-breakpoints and $container-max-widths are in ascending order; fixes #18549
  update shrinkwrap for f25f9bc
  Reboot: Update @viewport comment to account for de944e0
  Add $enable-print-styles variable for _print.scss; fixes #19101
  docs/components/modal.md: Fix typo
  Fixes #18550: really remove that reference
  grunt
  remove comment
  Updat modal sizing
  Follow up to #19099: Correct grid gutter value
  only do it for non-flex version
  Fixes #17969: Clear horizontal dls
  Revamp list group items built with anchors and buttons
  Fixes #17300: drop the unused at-viewports
  Tweak disabled button docs to help out #17231
  grunt
  Fixes #17194: Ensure proper height on default select.form-control instances
  clarify some docs for form validation including quick mention for customizing or disabling icons
  grunt
  Remove csscomb (soon replace it with something else) because scsslint has most of it covered already
  tweak sizing
  move the url to the variable value
  update to latest from @thekondrashov's jsfiddle
  grunt
  Fixes #18562: Disable Hound for Ruby
  migration notes for the text utils changes
  cross ref the type utils in the type docs
  rogue line break
  add note to migration docs
  Drop .center-block for .m-x-auto
  grunt
  Strip out .err from our syntax highlighting styles because it fucks up our placeholders in code snippets
  grunt
  unrelated linting bs
  linting grid css
  document
  Update to drop Open Sans, add Fira and Droid Sans
  mention media query changes
  document migration for grid system /cc #17593
  document how to customize grid tiers
  update grid vars docs
  formatting
  use px in grid col padding since we're using px everywhere else for them
  linting
  linter
  linter overhaul
  disable linter
  Ugh, Sass doesn't do extends across media, so we can't use placeholder here
  property order and white space
  property order
  More grid updates
  flip things around again, no more base class, try out some new stuff to keep responsive flex grid working
  simpler, more specific docs example css
  document horizontal flex utils, update the classes for the middle vertical ones
  add horizontal flex utils
  rename vertical align flex utils to middle to avoid clash with horizontal center
  more accurate comments
  Tweak docs example CSS for flexbox grid cols
  Add vertical alignment docs for flexbox grid
  Move the conditional statement back to the file because nested imports aren't supported in Sass
  Update devDependencies.
  Bump gems.
  rename .flex-all-* to .flex-items-* to match flexbox nomenclature
  Conditionally include the flex utils in the import stack and reduce to a single query
  Move grid flex classes to utils instead maybe?
  Update base class for grid cols in all examples
  Ensure docs grid example highlighting for flexbox mode
  Add flexbox grid page to the docs (still more content to add)
  Fix docs layout with added base class
  Update grid docs to include new required .col base class
  Revamp grid classes to require .col base class and improve flexbox grid classes with auto layout via flex: 1
  Update grid mixins code snippets in the docs to include flexbox changes
  Improve docs sidenav active link highlighting
  rearrange scss lint config to put flex over float
  Switch to native font stack
  grunt
  Remove pager section from migration
  Add Wall of Browser Bugs entry for https://webkit.org/b/153856
  Add migration guidance regarding vendor prefix mixins
  Revert separation of <hN> and .hN heading styles
  Mention https://webkit.org/b/153852 in browser compatibility docs
  Add Wall of Browser Bugs entry for https://webkit.org/b/153852
  grunt
  fuck that other class, let's just get tabs and pills in there
  grunt
  Dump the type margin overrides in alerts for utils, document that particular example, sidesteps part of #18884
  grunt
  Redo line-height globally
  center the nav
  update shrinkwrap
  Add docs for custom file input's text and $custom-file-text
  grunt
  Make translation of custom file input text easier; fixes #18922
  fuck around with card borders and more
  Use text-emphasis-variant mixin for .text-muted
  Alternative fix to double border
  Multiple input-group-addon support
  Fix size of validation feedback icons
  Add an empty line at the end of the file
  SVG: base64 > ASCII85 (fix merge)
  SVG: base64 > ASCII85
  The .text-hide won't hide the text :)
  compress SVGs
  replace PNG to SVG and compress SVGs

Signed-off-by: Torbjörn Klatt <t.klatt@fz-juelich.de>
85d212d
@torbjoernk torbjoernk added a commit to torbjoernk/jlesc.github.io that referenced this pull request Feb 23, 2016
@torbjoernk torbjoernk Adjusted CSS to recent changes in TWBS
These are mainly:
  - [#17194](twbs/bootstrap#17194)
  - [#18772](twbs/bootstrap#18772)
  - [#18782](twbs/bootstrap#18782)
  - [#19099](twbs/bootstrap#19099)
  - [#19102](twbs/bootstrap#19102)
  - [#19103](twbs/bootstrap#19103)

Signed-off-by: Torbjörn Klatt <t.klatt@fz-juelich.de>
b9e15a8
@glebm

@mdo We can use placeholders, but placeholders used within media queries the name should be unique per breakpoint, and defined within the media query for that breakpoint, e.g.: %column-basics for all-breakpoint attributes, and %column-basics-%{breakpoint} per breakpoint. This is how it used to be before this refactoring: https://github.com/twbs/bootstrap/blob/f88cbe7ee4e2b765b1c4c53efa9a5077e6a22529/scss/mixins/_grid-framework.scss#L24

@timalbert

I don't think v4 documentation for modifier is updated

@mdo mdo added a commit that referenced this pull request Jul 24, 2016
@mdo mdo Follow-up to #19099 for grid fixes
- Restores two-mixin approach to generating semantic grid columns (now with 'make-col-ready' and 'make-col')
- Removes need for .col-xs-12 by restoring the mass list of all grid tier classes to set position, min-height, and padding
- Adds an initial 'width: 100%' to flexbox grid column prep (later overridden by the column sizing in 'flex' shorthand or 'width') to prevent flexbox columns from collapsing in lower viewports
a8879c8
@mdo mdo added a commit that referenced this pull request Jul 27, 2016
@mdo mdo One more follow up to #19099, #20349, and #20361
Remove mention of base class and fix grid examples
ded1bf9
@mdo mdo added a commit that referenced this pull request Jul 27, 2016
@mdo mdo Customizing grid docs updates to followup on #19099
- More details on columns and gutters
- Break it into clear sections
55795e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment