Port v4 browser support table format to v3 #19273

Merged
merged 1 commit into from Feb 28, 2016

Projects

None yet

3 participants

@patrickhlauke
Member

Port of #18614 from v4 to v3

Ref #19269

@patrickhlauke
Member
@patrickhlauke
Member

@mdo @cvrebert thoughts on this? I note that the v4 tables included Android browser/ webview, while the v3 table didn't. That's my only concern here (the rest should be fairly non-controversial)

@cvrebert cvrebert commented on an outdated diff Feb 23, 2016
..._includes/getting-started/browser-device-support.html
<td class="text-muted">N/A</td>
+ <td class="text-success"><span class="glyphicon glyphicon-ok" aria-hidden="true"></span> Supported</td>
@cvrebert
cvrebert Feb 23, 2016 Member

Should read "Android v5.0+ supported" to match v4

@cvrebert
Member

If we're going to claim support for Edge, then we should add Edge to v3's Sauce testing config.

I slightly question adding the "feature" of AndroidBrowser+Edge+Win10Mobile official support this late in v3's lifecycle though.

@patrickhlauke
Member

Fair enough about not adding new browser combos. As an alternative, then, how about just porting the top/tail text, split into mobile/desktop, but leave actual table content unchanged?

@mdo
Member
mdo commented Feb 27, 2016

Fair enough about not adding new browser combos. As an alternative, then, how about just porting the top/tail text, split into mobile/desktop, but leave actual table content unchanged?

Updated table layout and more granular text is a-okay by me. I'd rather not sign us up for more/new browser combos as @cvrebert mentioned :).

@cvrebert
Member

As an alternative, then, how about just porting the top/tail text, split into mobile/desktop, but leave actual table content unchanged?

👍

@patrickhlauke patrickhlauke Port v4 browser support tables to v3
2d20bb7
@patrickhlauke
Member

rejigged the PR - this now ports the overall formatting, splitting the support table into separate mobile/desktop, but does not add any new browser combos (although I did add Microsoft Edge under the "Unofficially..." section, as from my experience it seems to all work fairly well there). Also, as Opera now falls under the "Alternative browsers which use the latest version of WebKit, Blink, or Gecko," bit, I removed it from the tables as well.

For a quick look of the end result of this, see http://www.bootply.com/oFgjmGsVGX

@patrickhlauke patrickhlauke added this to the v3.3.7 milestone Feb 27, 2016
@patrickhlauke patrickhlauke changed the title from Port v4 browser support tables to v3 to Port v4 browser support table format to v3 Feb 28, 2016
@patrickhlauke patrickhlauke merged commit 85c3cf1 into twbs:master Feb 28, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment