fix memory leak in tooltip $element #19659

Closed
wants to merge 1 commit into
from

Projects

None yet

7 participants

@gregsheremeta

Fixes #17973

@gregsheremeta gregsheremeta fix memory leak in tooltip $element. Fixes #17973
a9efd66
@cvrebert cvrebert added js v3 labels Apr 1, 2016
@cvrebert cvrebert changed the title from fix memory leak in tooltip $element. Fixes #17973 to fix memory leak in tooltip $element Apr 1, 2016
@cvrebert
Member
cvrebert commented Apr 1, 2016

@twbs-savage Retry

@twbs-savage
Member

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: a9efd66
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/120165154

(Please note that this is a fully automated comment.)

@cvrebert cvrebert added this to the v3.3.7 milestone Apr 1, 2016
@XhmikosR
Member

@cvrebert: I think this looks good. Can we merge or is there something else?

@cvrebert
Member

@XhmikosR I just wasn't sure (without taking time to trace thru the flow) what situation makes the if necessary.

@gregsheremeta

I'm not sure about the "if" either. The fix seemed to work without that extra "if" in our project, but according to #16451, some people need the extra "if". So I added it in there. It's just extra safety -- I see no harm in leaving it.

@cvrebert
Member

Guess we should merge and add a TODO to revisit the "if" later.

@XhmikosR
Member

@gregsheremeta: can you add the comment?

@cvrebert cvrebert closed this in f01f3e5 May 30, 2016
@mdo mdo referenced this pull request May 30, 2016
Closed

v3.3.7 ship list #18331

@cvrebert
Member

Merged as f01f3e5. (Rebased to add the comment in.)

@cvrebert
Member

@gregsheremeta Thanks!

@cvrebert
Member

Bookkeeping note: No corresponding patch appears to be required for v4, since it already nullifies the element instance variable upon tooltip destruction: https://github.com/twbs/bootstrap/blob/14c7ba95f97d853ef653893abfe530a919a1ed24/js/src/tooltip.js#L237

@kntmrkm
kntmrkm commented Jul 11, 2016

When release v3.3.7?

@cvrebert
Member

Some time in the next few weeks, most likely. As always, no absolute guarantee though.

@Herst
Herst commented Jul 26, 2016

The TODO comment is part of the release now.

@cvrebert
Member

That's fine.

@natalan
natalan commented Sep 14, 2016

It looks like this PR is a root cause for #20511

@gregsheremeta

Probably want to add that "if" back in then

@msmolens msmolens referenced this pull request in ImageMarkup/isic-archive Nov 11, 2016
Open

Tooltips cause detached DOM elements #290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment