WIP as I slog through #18467.
Still to do:
Alternate fix to #18865: Change the .navbar-toggler color for light/d…
…ark navbars as we do with the .navbar-brand
Update collapsible navbar docs
- Add .text-muted for text color control over .bg-inverse in the examples
- Add a dark navbar collapse example
clarify example with code comment
add new variable for -toggle-font-size
new var for -toggle-border-radius
more navbar variables
Add dropdown menu example to navbar docs
add docs note to clear up #18599--active states for navbars can be on…
… anchors or parents
Merge branch 'v4-navbars' of https://github.com/twbs/bootstrap into v…
follow up to c6c0522: define those new vars
Restore .navbar-text and add some basic examples to the docs /cc #18049
improve docs examples for .navbar-text
Is there anything preventing this from being merged in dev branch? I might not really understand completely how it all works yet... sorry.
Is it waiting the "alpha.3" milestone reach? Or is it something else that I don't get?
@os1r1s110 as first words in PR's say, this is work in progress PR that aims to solve certain issues within BS4's navbars that are tracked here:
It'll likelly get merged when it's considered done by the author... unless @mdo decides to split the work in few PR's and merges what he has done so far.
@rafalp I did effectively read that this was WIP, but you know sometimes in big open source projects, some open PR get lost in the sea of PRs and other issues so I just wanted to know what was up with this one as there had been no update since a couple of weeks, that's it.... :|
As you can also see my comment on #18467, there has also been no update since a long time in this PR so I kind of just wanted to get an update on the status and verify if it was still at this state or not for the progress. Reading your answer I guess that it does...
@os1r1s110 It seems that @mdo has reduced his commitment to the project lately:
It may suck if you are waiting for Mark to wrap up his PR's, but that's how it is with open source. Give it time, I'm wholly expecting @mdo to come from nowhere one day and push boatload of work into BS4 ;)
Ahah yeah, I couldn't say it sucks to wait for him to close up the navbar PRs because I can't complete them myself so I can't complain.
I'm pretty new to frontend development so I'm trying to build my own version of navbar and just cut it from the bootstrap alpha 2 build to avoid compatibility issues.
Merge branch 'v4-dev' into v4-navbars
Fixes #17990: clear the floats within .navbar-toggleable-* to avoid f…
…unky animation on close
@mdo - do dropdowns need adding to navbars - or are they abstracted from the navbar docs now?
Fixes #20543: Significantly darken the links in default navbars
Added #20543 to this PR to address color contrast a bit.
fix that navbar toggler example in docs
fix bad merge
remove those files from the diff
Merge branch 'v4-navbars' of github.com:twbs/bootstrap into v4-navbars
drop data-target so the dropdown link works
Iterate over breakpoints to generate .navbar-toggleable classes
- Moves .navbar-brand margin and float to media queries
- Replaces the static media queries with an each loop to generate all the needed classes
Fix sass map navbar-toggleable
Follow up to 6e8ce0c. Uses the breakpoint-next mixin to snag the next breakpoint in the media query for proper styling.
set the border color on the toggler
add navbar-brand and navbar-nav styles to the toggleable
document new navbar classes and styles, update responsive variation, …
…fix broken float classes
more html linting
Pushed a few major changes to this the last few days. The toggler has been updated, toggleable classes are now generated from the breakpoint Sass map, and docs updated. Overall I think this is in a solid enough place to build on just a tad more in Alpha 6. Definitely want folks to try using it more.
more consistent navbar-brand line-height
remove .navbar-brand > img selector that sets display block (will be …
…replaced with utils)
add examples of images in the navbar-brand section
Updated opening comment with clearer list of issues this all fixes, and the remaining todos.
Tweak that navbar brand image alignment with new vertical align utils
More navbar example content with forms
Punting on some of this for Alpha 6. Trying to wrangle all this ahead of dropping Alpha 5 tomorrow, so apologies for the potentially half baked ship here. 😬
Going to track remaining work for Alpha 6 in #20937.