Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Navbar improvements #19890

Merged
merged 41 commits into from Oct 19, 2016
Merged

v4: Navbar improvements #19890

merged 41 commits into from Oct 19, 2016

Conversation

@mdo
Copy link
Member

@mdo mdo commented May 12, 2016

WIP as I slog through #18467.


  • New Sass variables for various navbar components.
  • #17250: Improved (and highly flexible) responsive behaviors added.
  • #17532: Dropdown example for navbars.
  • #17539 , #18863, #18865: Navbar togglers don't respect color scheme.
  • 083271a: Update collapsible navbar docs to demonstrate color scheme functionality of navbar toggler.
  • #17990, #20392, #20749: Clear the floats within .navbar-toggleable-* to avoid broken animation on close.
  • #18049: Restore .navbar-text and add some docs examples.
  • #18855: Docs for examples of using images in navbar brand component.
  • #18599: Clarify usage of .active in navbar navs.
  • #20543: Improve color contrast of navbar nav links.
  • #20856: Navbar brand and image options (solved thanks to utilities).

Still to do:

  • #18053: Container adding extra padding
  • #18115: Revisit light/dark nomenclature
  • #18557: Make sure docs navbar is updated
  • #18751: Input group sizing in navbar
  • #18875: Flexbox navbar
  • Migration docs
mdo added 2 commits May 12, 2016
…ark navbars as we do with the .navbar-brand
- Add .text-muted for text color control over .bg-inverse in the examples
- Add a dark navbar collapse example
@lvmajor
Copy link

@lvmajor lvmajor commented Jul 19, 2016

Is there anything preventing this from being merged in dev branch? I might not really understand completely how it all works yet... sorry.

Is it waiting the "alpha.3" milestone reach? Or is it something else that I don't get?

@rafalp
Copy link

@rafalp rafalp commented Jul 19, 2016

@os1r1s110 as first words in PR's say, this is work in progress PR that aims to solve certain issues within BS4's navbars that are tracked here:

#18467

It'll likelly get merged when it's considered done by the author... unless @mdo decides to split the work in few PR's and merges what he has done so far.

@lvmajor
Copy link

@lvmajor lvmajor commented Jul 19, 2016

@rafalp I did effectively read that this was WIP, but you know sometimes in big open source projects, some open PR get lost in the sea of PRs and other issues so I just wanted to know what was up with this one as there had been no update since a couple of weeks, that's it.... :|

As you can also see my comment on #18467, there has also been no update since a long time in this PR so I kind of just wanted to get an update on the status and verify if it was still at this state or not for the progress. Reading your answer I guess that it does...

@rafalp
Copy link

@rafalp rafalp commented Jul 19, 2016

@os1r1s110 It seems that @mdo has reduced his commitment to the project lately:

https://twitter.com/mdo/status/745652402687090688
https://twitter.com/mdo/status/745667785758388224
https://twitter.com/mdo/status/745734499586056192

It may suck if you are waiting for Mark to wrap up his PR's, but that's how it is with open source. Give it time, I'm wholly expecting @mdo to come from nowhere one day and push boatload of work into BS4 ;)

@lvmajor
Copy link

@lvmajor lvmajor commented Jul 19, 2016

Ahah yeah, I couldn't say it sucks to wait for him to close up the navbar PRs because I can't complete them myself so I can't complain.

I'm pretty new to frontend development so I'm trying to build my own version of navbar and just cut it from the bootstrap alpha 2 build to avoid compatibility issues.

@mdo
Copy link
Member Author

@mdo mdo commented Oct 18, 2016

Pushed a few major changes to this the last few days. The toggler has been updated, toggleable classes are now generated from the breakpoint Sass map, and docs updated. Overall I think this is in a solid enough place to build on just a tad more in Alpha 6. Definitely want folks to try using it more.

@mdo
Copy link
Member Author

@mdo mdo commented Oct 19, 2016

Updated opening comment with clearer list of issues this all fixes, and the remaining todos.

@mdo
Copy link
Member Author

@mdo mdo commented Oct 19, 2016

Punting on some of this for Alpha 6. Trying to wrangle all this ahead of dropping Alpha 5 tomorrow, so apologies for the potentially half baked ship here. 😬

@mdo mdo merged commit 028dd6b into v4-dev Oct 19, 2016
3 of 4 checks passed
3 of 4 checks passed
savage Savage has initiated its special separate Travis CI build
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
hound No violations found. Woof!
@mdo mdo deleted the v4-navbars branch Oct 19, 2016
@mdo
Copy link
Member Author

@mdo mdo commented Oct 19, 2016

Going to track remaining work for Alpha 6 in #20937.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.