-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove forced default focus outline #19935
Conversation
As this causes non-standard dotted outline on checkboxes/radio buttons in Firefox/OSX
Any adverse effect on IE or Win Firefox? |
will post some screenshots in a bit, but generally: no adverse effect (though subtly different, checkboxes, tabs - in navs - etc all still have a good focus indication) |
some before/after shots. for IE11, removing that explicit outline effectively brings the outline back to its natural look (i.e. links, buttons and checkboxes do have that particular outline normally) for Firefox/Windows, the notable change is that |
Ported to v4 in #20275. |
As this causes non-standard dotted outline on checkboxes/radio buttons in OS X Firefox Ports twbs#19935 to v4 Refs twbs#19933 [skip sauce]
As this causes non-standard dotted outline on checkboxes/radio buttons in OS X Firefox Fixes twbs#19933 Closes twbs#19935 [skip sauce]
the current
outline: thin dotted
that is forced as "default" is not in fact default in Firefox/OS X; forcing it leads to unsightly dotted outline that's non-standard for the browser/platform.removing it seems to have no adverse effect in other all situations where this mixin is used (buttons, scaffolding for general link styles, and the case of forms). attempted to use
outline: initial
at first, but this seems somehow broken in Firefox (ends up removing standard Firefox dotted outline on links).This is mostly a bug-fix, rather than a new feature (hence targetting it for v3)
Closes #19933