Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wall of Browser Bugs entries for Selectors Level 4 :nth-child(An+B of S) #20143

Merged
merged 1 commit into from Jun 22, 2016

Conversation

Projects
None yet
3 participants
@cvrebert
Copy link
Member

cvrebert commented Jun 20, 2016

I propose adding these on the grounds that the of S feature would allow us to make our widgets more robust. We've had several issue reports (e.g. #15684, #13825, #16540) where folks tried to put stuff like <input type="hidden"> within .input-group or .btn-group, but this broke the :first-child/:last-child-based selectors we use to adjust rounded corners.
With this feature, we could restrict the children considered to only the relevant ones, thus ignoring other irrelevant elements. For example, we could use :nth-child(1 of .btn) in our .btn-group CSS to ignore non-.btn children and thus round the corners correctly in such cases.

Refs:

CC: @twbs/team for review

@cvrebert cvrebert added this to the v4.0.0-alpha.3 milestone Jun 20, 2016

@hnrch02

This comment has been minimized.

Copy link
Member

hnrch02 commented Jun 20, 2016

👍

With regards to the feature: Is it backwards compatible? I presume it isn't.

@cvrebert

This comment has been minimized.

Copy link
Member Author

cvrebert commented Jun 20, 2016

AIUI, it isn't. We'd probably only be able to use it in the far future when IE has been dropped completely. But I think we'd like this feature to be ready by the time that world arrives.

@cvrebert

This comment has been minimized.

Copy link
Member Author

cvrebert commented Jun 22, 2016

@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Jun 22, 2016

LGTM although I do feel it's a little early but it doesn't hurt.

@cvrebert cvrebert merged commit d39e243 into v4-dev Jun 22, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
hound No violations found. Woof!

@cvrebert cvrebert deleted the nth-child-of branch Jun 22, 2016

cvrebert added a commit that referenced this pull request Jun 22, 2016

Port #20143 to v3
Add Wall of Browser Bugs entries for Selectors Level 4 :nth-child() (#20143)

Refs http://caniuse.com/#feat=css-nth-child-of
Refs https://drafts.csswg.org/selectors-4/#the-nth-child-pseudo
Refs https://crbug.com/304163
Refs https://bugzil.la/854148

[skip sauce]

twbs-savage pushed a commit to twbs-savage/bootstrap that referenced this pull request Sep 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.