Backport JS unit test fixes from v4 #20259

Merged
merged 2 commits into from Jul 8, 2016

Projects

None yet

2 participants

@cvrebert
Member
cvrebert commented Jul 8, 2016

Refs #16834.

dmethvin added some commits Jun 28, 2016
@dmethvin @cvrebert dmethvin Port #20190 to v3
Scrollspy test: Allow for async .then() in jQuery 3; fixes #20182

Instead of doing a new assert.async(), just do a single one for the entire test
and let the .then() be async as well.
4a8b29f
@dmethvin @cvrebert dmethvin Port #20198 to v3
ScrollSpy unit test: Use single done() in a then() instead of multiple done()s

Fixes test flakiness on OS X Safari and Android when using jQuery 3.
Fixes #20182 more
Refs #20191
bc05ef1
@cvrebert cvrebert added js v3 labels Jul 8, 2016
@cvrebert cvrebert added this to the v3.3.7 milestone Jul 8, 2016
@cvrebert cvrebert merged commit 415f144 into master Jul 8, 2016

0 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
hound Hound is busy reviewing changes...
@cvrebert cvrebert deleted the backport-unit-fixes branch Jul 8, 2016
@mdo mdo referenced this pull request Jul 25, 2016
Closed

v3.3.7 ship list #18331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment