Update jQuery version check and jQuery dependency version range #20338

Merged
merged 1 commit into from Jul 21, 2016

Projects

None yet

5 participants

@cvrebert
Member

Closes #16834.
CC: @XhmikosR @hnrch02 for review

@cvrebert cvrebert Update jQuery version check and jQuery dependency version range
Closes #16834

[skip validator]
3f13774
@cvrebert cvrebert added js meta v3 labels Jul 21, 2016
@cvrebert cvrebert added this to the v3.3.7 milestone Jul 21, 2016
@XhmikosR
Member

:shipit:

@twbs-savage
Member

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 3f13774
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/146311640
Docs preview: http://preview.twbsapps.com/c/${commitSha.sha}

(Please note that this is a fully automated comment.)

@hnrch02
Member
hnrch02 commented Jul 21, 2016

:shipit:

@cvrebert cvrebert merged commit edefe0e into master Jul 21, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
hound No violations found. Woof!
savage CONFIRMED: Savage cross-browser JS tests passed
@cvrebert cvrebert deleted the fix-16834 branch Jul 21, 2016
@chowyb chowyb referenced this pull request in TEAMMATES/teammates Jul 22, 2016
Merged

Add VersionEye to the repo #5599 #5899

@Martii
Martii commented Jul 24, 2016

Hate to be the bearer of some potentially bad news... but when we switch to jQuery 3.0.0 or 3.1.0 modal dialog boxes fail to launch in the UI. Works fine in 2.2.4 of jQuery.

@cvrebert
Member

@Martii Post a JS Bin testcase please.

@Martii
Martii commented Jul 24, 2016

I'm seeing if the "newer" props listed at http://v4-alpha.getbootstrap.com/components/modal/#live-demo would affect this. I'm not sure where it's failing between the dependency of jQuery and boostrap just yet but since I'm the maintainer for dep updates we haven't been able to migrate to v3.x of jQuery using bootstrap v3.3.6.

@Martii
Martii commented Jul 24, 2016 edited

@cvrebert
I also see the live demo link I referenced is using an even older version jQuery... so that invalidates the success of the demo since it's not using v3.x.

Generated source for that url:

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.4/jquery.min.js"></script>

And the release version of bootstrap is:

<script src=https://ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js>

... which is even older and invalidates the success of current release since it's not using jQuery v3.x

@XhmikosR
Member

The docs aren't the latest from git. If you think you have an issue post a
jsfiddle.

On Jul 25, 2016 02:20, "Marti Martz" notifications@github.com wrote:

@cvrebert https://github.com/cvrebert
I also see the live demo link I reference is using an even older version
jQuery... so that invalidates the success of the demo since it's not using
v3.x.

Generated source for that url:

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.4/jquery.min.js"></script>


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#20338 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAVVtc5PTttgn2wEbi1PoyhiKK6TQOJAks5qY_M6gaJpZM4JRioS
.

@Martii
Martii commented Jul 24, 2016

@XhmikosR
I prefer gists and one can just click the raw button... since you say the docs are invalid I have no real way of telling if we are missing a html property for jQuery 3.x compatibility... so the issue to be created would be to update the docs first so I can see if an attribute may be missing on our end. I can strip out the live demo source and update jQuery there and see if it works first which is the most logical course of action.

@XhmikosR
Member

Development doesn't happen on a live site. Use the appropriate git branch
to test the development progress.

On Jul 25, 2016 02:37, "Marti Martz" notifications@github.com wrote:

@XhmikosR https://github.com/XhmikosR
I prefer gists and one can just click the raw button... since you say the
docs are invalid I have no real way of telling if we are missing a html
property for jQuery 3.x compatibility... so the issue to be created would
be to update the docs first so I can see if an attribute may be missing on
our end. I can strip out the live demo source and update jQuery there and
see if it works first which is the most logical course of action.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#20338 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAVVtYeLzNucOyECVJ81LDwNVtfK102Zks5qY_ctgaJpZM4JRioS
.

@Martii
Martii commented Jul 25, 2016

@cvrebert
Ah I see now... you are fixing the incompatibility using jQuery 3.x in this PR... e.g. the current release of bootstrap is a little too strict on a compatibility check and throws an error which makes it a flaw in bootstrap. Nice find/work btw and thank you. I will look forward to a bootstrap 3 release that has this issue fixed... and hopefully the documentation from the maintainers can reflect things a little better/recent in the future.

Ref:

Timestamp: 07/24/2016 06:20:01 PM
Error: Error: Bootstrap's JavaScript requires jQuery version 1.9.1 or higher, but lower than version 3
Source File: http://localhost:8080/redist/npm/bootstrap/dist/js/bootstrap.js
Line: 1
@Martii Martii referenced this pull request in OpenUserJs/OpenUserJS.org Jul 25, 2016
Merged

Some dep updates #1020

@cvrebert
Member

Manually confirmed (in OS X Chrome & Firefox) that the modals work fine with jQuery 3.1.0.

@cvrebert cvrebert locked and limited conversation to collaborators Jul 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.