v4 : Making .tooltip('show') throw an error on elements with display:none #20940
Conversation
| try { | ||
| $('<div title="tooltip title" style="display: none"/>').bootstrapTooltip('show') | ||
| } | ||
| catch (err) { |
There was a problem hiding this comment.
Closing curly brace does not appear on the same line as the subsequent block brace-style
| try { | ||
| $('<div title="tooltip title" style="display: none"/>').bootstrapTooltip('show') | ||
| } | ||
| catch (err) { |
There was a problem hiding this comment.
Closing curly brace does not appear on the same line as the subsequent block brace-style
| try { | ||
| $('<div title="tooltip title" style="display: none"/>').bootstrapTooltip('show') | ||
| } | ||
| catch (err) { |
There was a problem hiding this comment.
Closing curly brace does not appear on the same line as the subsequent block brace-style
| @@ -185,6 +185,19 @@ $(function () { | |||
| .bootstrapTooltip('show') | |||
| }) | |||
|
|
|||
| QUnit.test('should throw an error when show is called on hidden elements', function (assert) { | |||
| assert.expect(1) | |||
| var done = assert.async() | |||
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
| @@ -185,6 +185,19 @@ $(function () { | |||
| .bootstrapTooltip('show') | |||
| }) | |||
|
|
|||
| QUnit.test('should throw an error when show is called on hidden elements', function (assert) { | |||
| assert.expect(1) | |||
| var done = assert.async() | |||
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
| @@ -185,6 +185,19 @@ $(function () { | |||
| .bootstrapTooltip('show') | |||
| }) | |||
|
|
|||
| QUnit.test('should throw an error when show is called on hidden elements', function (assert) { | |||
| assert.expect(1) | |||
| var done = assert.async() | |||
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
| @@ -185,6 +185,19 @@ $(function () { | |||
| .bootstrapTooltip('show') | |||
| }) | |||
|
|
|||
| QUnit.test('should throw an error when show is called on hidden elements', function (assert) { | |||
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
| @@ -185,6 +185,19 @@ $(function () { | |||
| .bootstrapTooltip('show') | |||
| }) | |||
|
|
|||
| QUnit.test('should throw an error when show is called on hidden elements', function (assert) { | |||
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
| @@ -185,6 +185,19 @@ $(function () { | |||
| .bootstrapTooltip('show') | |||
| }) | |||
|
|
|||
| QUnit.test('should throw an error when show is called on hidden elements', function (assert) { | |||
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
| try { | ||
| $('<div data-toggle="popover" data-title="some title" data-content="@Johann-S" style="display: none"/>').bootstrapPopover('show') | ||
| } | ||
| catch (err) { |
There was a problem hiding this comment.
Closing curly brace does not appear on the same line as the subsequent block brace-style
| try { | ||
| $('<div data-toggle="popover" data-title="some title" data-content="@Johann-S" style="display: none"/>').bootstrapPopover('show') | ||
| } | ||
| catch (err) { |
There was a problem hiding this comment.
Closing curly brace does not appear on the same line as the subsequent block brace-style
| try { | ||
| $('<div data-toggle="popover" data-title="some title" data-content="@Johann-S" style="display: none"/>').bootstrapPopover('show') | ||
| } | ||
| catch (err) { |
There was a problem hiding this comment.
Closing curly brace does not appear on the same line as the subsequent block brace-style
| @@ -320,4 +320,16 @@ $(function () { | |||
| .bootstrapPopover('show') | |||
| }) | |||
|
|
|||
| QUnit.test('should throw an error when show is called on hidden elements', function (assert) { | |||
| assert.expect(1) | |||
| var done = assert.async() | |||
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
| @@ -320,4 +320,16 @@ $(function () { | |||
| .bootstrapPopover('show') | |||
| }) | |||
|
|
|||
| QUnit.test('should throw an error when show is called on hidden elements', function (assert) { | |||
| assert.expect(1) | |||
| var done = assert.async() | |||
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
| @@ -320,4 +320,16 @@ $(function () { | |||
| .bootstrapPopover('show') | |||
| }) | |||
|
|
|||
| QUnit.test('should throw an error when show is called on hidden elements', function (assert) { | |||
| assert.expect(1) | |||
| var done = assert.async() | |||
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
| @@ -320,4 +320,16 @@ $(function () { | |||
| .bootstrapPopover('show') | |||
| }) | |||
|
|
|||
| QUnit.test('should throw an error when show is called on hidden elements', function (assert) { | |||
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
| @@ -320,4 +320,16 @@ $(function () { | |||
| .bootstrapPopover('show') | |||
| }) | |||
|
|
|||
| QUnit.test('should throw an error when show is called on hidden elements', function (assert) { | |||
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
| @@ -320,4 +320,16 @@ $(function () { | |||
| .bootstrapPopover('show') | |||
| }) | |||
|
|
|||
| QUnit.test('should throw an error when show is called on hidden elements', function (assert) { | |||
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
Johann-S
changed the title
|
I know it's not a major feature but If you can review this PR @mdo or @bardiharborow thank you ❤️ |
|
I don't know jack about JS, but I like this as a preventative feature. |
I made this PR for this feature request in #17021 :