Travis build infrastructure refresh. #21108

Merged
merged 1 commit into from Dec 5, 2016

Projects

None yet

4 participants

@bardiharborow
Member
bardiharborow commented Nov 9, 2016 edited

Resolves #17163. Ubuntu Trusty containers are now available on Travis, removing the last obstacle stopping us moving to the container based environment. This cuts build times by about 15 seconds.

Regarding the other changes: Ruby 2.3.1 comes preinstalled on the new images, so I have removed the install directive. The npm install directive has been made conditional as only the Node 4.x environment will have npm 2.x. --retry=3 has been added to the bundler command to bring it in line with Travis' default and to provide greater network stability. NPM_CONFIG_PROGRESS="false" has been removed as npm/npm#11283 seems to be fixed. Git --depth has been lowered.

Coming soon in another PR, is switching to using the Travis apt addon to download the Google Cloud SDK (blocked on travis-ci/apt-package-whitelist#3515) and switching to using the Travis sauce_connect addon rather than using grunt-saucelabs (blocked on further investigation).

@@ -361,7 +358,7 @@ module.exports = function (grunt) {
if (typeof process.env.SAUCE_ACCESS_KEY !== 'undefined' &&
// Skip Sauce if running a different subset of the test suite
runSubset('sauce-js-unit')) {
- testSubtasks = testSubtasks.concat(['dist', 'docs-css', 'docs-js', 'clean:docs', 'copy:docs', 'exec:upload-preview']);
+ testSubtasks = testSubtasks.concat(['dist', 'docs-css', 'docs-js', 'clean:docs', 'copy:docs']);
@houndci-bot
houndci-bot Nov 9, 2016

Extra semicolon semi

@mdo mdo added grunt v4 labels Nov 10, 2016
@@ -361,7 +358,7 @@ module.exports = function (grunt) {
if (typeof process.env.SAUCE_ACCESS_KEY !== 'undefined' &&
// Skip Sauce if running a different subset of the test suite
runSubset('sauce-js-unit')) {
- testSubtasks = testSubtasks.concat(['dist', 'docs-css', 'docs-js', 'clean:docs', 'copy:docs', 'exec:upload-preview']);
+ testSubtasks = testSubtasks.concat(['dist', 'docs-css', 'docs-js', 'clean:docs', 'copy:docs']);
@houndci-bot
houndci-bot Nov 24, 2016

Extra semicolon semi

@mdo
Member
mdo commented Nov 26, 2016

@cvrebert Wanna take a look at this and let me know what you think? <3

@mdo mdo modified the milestone: v4.0.0-alpha.6 Nov 28, 2016
.travis.yml
- - npm install
+ - npm install --only=development
+after_success:
+ - grunt/upload-preview.sh
@cvrebert
cvrebert Nov 29, 2016 Member

This was where it was in the Gruntfile so that it would only run only when the docs had actually been built, and so it would only run once (instead of 3x on account of the build matrix).

@bardiharborow
bardiharborow Nov 29, 2016 Member

Ah. I was mainly moving this out of the Gruntfile as part of the whole move to npm scripts, but I forgot about the whole build matrix issue. I've added a condition on the front. I can move back to the Gruntfile if you really don't like it here.

matrix:
- fast_finish: true
@cvrebert
cvrebert Nov 29, 2016 Member

Removed because...?

@bardiharborow
bardiharborow Nov 29, 2016 Member

fast_finish only seems to have meaning where there are allowed failures.

.travis.yml
- cp grunt/npm-shrinkwrap.json ./
- - npm install
+ - npm install --only=development
@cvrebert
cvrebert Nov 29, 2016 Member

If we ever sort out the "use ES6 imports for our deps" issue, then we'll need the non-dev dependencies (jQuery, Tether, etc.)

@bardiharborow
bardiharborow Nov 29, 2016 Member

Good point.

@cvrebert
Member

and switching to using the Travis sauce_connect addon rather than using grunt-saucelabs

See #18754. BrowserStack seems like our best option IMHO.

@@ -361,7 +358,7 @@ module.exports = function (grunt) {
if (typeof process.env.SAUCE_ACCESS_KEY !== 'undefined' &&
// Skip Sauce if running a different subset of the test suite
runSubset('sauce-js-unit')) {
- testSubtasks = testSubtasks.concat(['dist', 'docs-css', 'docs-js', 'clean:docs', 'copy:docs', 'exec:upload-preview']);
+ testSubtasks = testSubtasks.concat(['dist', 'docs-css', 'docs-js', 'clean:docs', 'copy:docs']);
@houndci-bot
houndci-bot Nov 29, 2016

Extra semicolon semi

@bardiharborow
Member

See #18754. BrowserStack seems like our best option IMHO.

Ah. I saw that but I wasn't sure if it was still on the table.

@bardiharborow bardiharborow Travis build infrastructure refresh.
0ec9aa4
@mdo mdo merged commit 5a19d48 into twbs:v4-dev Dec 5, 2016

1 of 2 checks passed

hound 1 violation found.
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mdo mdo referenced this pull request Dec 5, 2016
Closed

v4 Alpha 6 ship list #20939

@bardiharborow bardiharborow deleted the bardiharborow:travis branch Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment