Move node-sass to npm script and drop Ruby Sass. #21489

Merged
merged 2 commits into from Jan 4, 2017

Projects

None yet

4 participants

@bardiharborow
Member

This PR moves node-sass to a NPM script.

Per #20332, I've also dropped Ruby Sass support:

Compile Sass files with node-sass (no more Ruby options)

@bardiharborow bardiharborow added this to the v4.0.0-alpha.6 milestone Jan 1, 2017
@hnrch02
Member
hnrch02 commented Jan 1, 2017

Do we know if libsass finally achieved feature parity with sass? A comparison in output for the unminified file would be handy, I think. (Unless this has already been examined and I'm OOTL.)

@bardiharborow
Member

Bootstrap already uses libsass by default, so this doesn't change that. The only differences in the output between libsass and Ruby Sass are to do with how whitespace is treated (I had to use --ignore-blank-lines to avoid diffing hundreds of added lines.) As for whether this will disrupt anyone, I posted a heads up on Slack and haven't heard any complaints.

@mdo
mdo approved these changes Jan 2, 2017 View changes

Let's do it! Looks like tests are failing for some linting issues, otherwise looks good to me!

bardiharborow added some commits Jan 3, 2017
@bardiharborow bardiharborow Move node-sass to npm script and drop Ruby Sass. d3611fe
@bardiharborow bardiharborow Update shrinkwrap.
6cf52b7
@bardiharborow bardiharborow requested a review from hnrch02 Jan 3, 2017
@bardiharborow
Member
bardiharborow commented Jan 3, 2017 edited

@hnrch02 did you have any further concerns or shall we LGTM? I've fixed the linting issue.

@hnrch02
hnrch02 approved these changes Jan 3, 2017 View changes

Seems like I was just out of the loop on ruby Sass 😄 LGTM!

@bardiharborow bardiharborow merged commit dd19670 into twbs:v4-dev Jan 4, 2017

1 of 3 checks passed

hound 2 violations found.
savage Savage has initiated its special separate Travis CI build
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bardiharborow bardiharborow deleted the bardiharborow:npm-sass branch Jan 4, 2017
@mdo mdo referenced this pull request Jan 4, 2017
Closed

v4 Alpha 6 ship list #20939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment