Remove unused scss variables #21579

Merged
merged 4 commits into from Jan 16, 2017

Projects

None yet

3 participants

@vanduynslagerp
Contributor

Fixes #21551

Remove unused scss variables mentioned in #21551 and a few more.

@vanduynslagerp vanduynslagerp Remove unused scss variables
632e586
@Quy
Contributor
Quy commented Jan 6, 2017

On this page too. Thanks.
https://v4-alpha.getbootstrap.com/layout/overview/

vanduynslagerp added some commits Jan 6, 2017
@vanduynslagerp vanduynslagerp Remove unnecessary space 0d617da
@vanduynslagerp vanduynslagerp Remove $zindex-navbar from docs
6973430
@vanduynslagerp
Contributor

Done. Good catch @Quy !

@mdo mdo added css v4 labels Jan 6, 2017
@mdo mdo added this to the v4.0.0-beta milestone Jan 6, 2017
scss/_variables.scss
@@ -851,7 +832,6 @@ $progress-height: 1rem !default;
$progress-font-size: .75rem !default;
$progress-bg: $gray-lighter !default;
$progress-border-radius: $border-radius !default;
-$progress-box-shadow: inset 0 .1rem .1rem rgba($black,.1) !default;
@mdo
mdo Jan 6, 2017 Member

This one can remain; I'll need to add a conditional shadow to the .progress to make use of it.

@vanduynslagerp vanduynslagerp Re-add $progress-box-shadow
964938d
@vanduynslagerp
Contributor

Re-added $progress-box-shadow

@mdo mdo merged commit a3bc607 into twbs:v4-dev Jan 16, 2017

2 of 3 checks passed

savage Savage has initiated its special separate Travis CI build
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
@mdo mdo referenced this pull request Jan 16, 2017
Open

Beta 1 ship list #21568

@vanduynslagerp vanduynslagerp deleted the vanduynslagerp:remove-unused-variables branch Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment