Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate series of `.table-responsive-*` classes to accomodate overflowing tables in a variety of screen sizes #22804

Merged
merged 2 commits into from Aug 22, 2017

Conversation

@pat270
Copy link
Contributor

pat270 commented Jun 12, 2017

The old .table-responsive was nice because it helped manage unwieldy tables. This adds responsive tables at all screen sizes and at each breakpoint, .table-responsive, .table-responsive-sm, .table-responsive-md, .table-responsive-lg, and .table-responsive-xl respectively.

@pat270 pat270 changed the title enerate series of `.table-responsive-*` classes to accomodate overflowing tables in a variety of screen sizes Generate series of `.table-responsive-*` classes to accomodate overflowing tables in a variety of screen sizes Jun 12, 2017
@Johann-S Johann-S added css v4 labels Jun 12, 2017
@mdo

This comment has been minimized.

Copy link
Member

mdo commented Jun 13, 2017

Dang, that's a rad update. Slating for Beta 2!

@mdo mdo added this to Needs review in v4 Beta 2 Jun 13, 2017
@mdo
mdo approved these changes Aug 22, 2017
@mdo mdo merged commit c1865b4 into twbs:v4-dev Aug 22, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
@mdo mdo moved this from Needs review to Shipped in v4 Beta 2 Aug 22, 2017
This was referenced Aug 22, 2017
@tmorehouse tmorehouse mentioned this pull request Aug 26, 2017
45 of 56 tasks complete
@browner12

This comment has been minimized.

Copy link
Contributor

browner12 commented Sep 3, 2017

@pat270 nice PR. can you confirm the behavior of this feature? most of our responsive classes work by applying the state to everything above them. This ones works the opposite direction, correct?

If I say table-responsive it will only apply to XS sizes, and if I say table-responsive-xl it will apply to all sizes, correct?

Thanks!

@pat270

This comment has been minimized.

Copy link
Contributor Author

pat270 commented Sep 5, 2017

@browner12 It's actually the other way around. table-responsive applies to all sizes and table-responsive-xl applies to screen sizes 1199px and below.

https://github.com/twbs/bootstrap/blob/v4-dev/docs/4.0/content/tables.md#responsive-tables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v4 Beta 2
Shipped
4 participants
You can’t perform that action at this time.