Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes badge-pill-border-radius variable from 10px to 50 percent to ensure ro… #23439

Closed

Conversation

@andresgalante
Copy link
Member

commented Aug 14, 2017

Hi! Variables.scss reads:

// Use a higher than normal value to ensure completely rounded edges when
// customizing padding or font-size on labels.
$badge-pill-border-radius:    10rem !default;

If we want to ensure completely rounded edges, that value should be 50%. This PR changes it to:

$badge-pill-border-radius:    50% !default;

What do you think?

@Johann-S Johann-S added css v4 labels Aug 14, 2017

@mdo

This comment has been minimized.

Copy link
Member

commented Aug 14, 2017

Doesn't work like that: https://codepen.io/anon/pen/vJezWQ

@mdo mdo closed this Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.