New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to stylelint. #23572

Merged
merged 2 commits into from Oct 3, 2017

Conversation

Projects
7 participants
@XhmikosR
Member

XhmikosR commented Aug 20, 2017

Fixes #23383

Note to all: feel free to push to this branch, and merge from v4-dev, but please do not rebase until we are ready to merge to v4-dev.

TODO:

  • Make sure tests are green
  • Check for properties order
  • Tighten rules
  • Make sure Hound works

@XhmikosR XhmikosR requested review from mdo, bardiharborow and Johann-S Aug 20, 2017

@wojtask9

This comment has been minimized.

Show comment
Hide comment
@wojtask9

wojtask9 Aug 21, 2017

Contributor

Probably you also want to use stylelint-order plugin.

Contributor

wojtask9 commented Aug 21, 2017

Probably you also want to use stylelint-order plugin.

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Aug 21, 2017

Member

Yup, it's on my todo, but I thought I'd let the other team members chime in before I make a lot more changes myself :)

Member

XhmikosR commented Aug 21, 2017

Yup, it's on my todo, but I thought I'd let the other team members chime in before I make a lot more changes myself :)

@andresgalante

This comment has been minimized.

Show comment
Hide comment
@andresgalante

andresgalante Aug 21, 2017

Member

It'd be great if we make style lint format the code or use another formater.
Fornater + lint = happiness

Love this change 👍🏻

Member

andresgalante commented Aug 21, 2017

It'd be great if we make style lint format the code or use another formater.
Fornater + lint = happiness

Love this change 👍🏻

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Sep 30, 2017

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@@ -117,9 +122,7 @@
"build",
"js/.eslintrc.json",
"js/**/*.js",
".scss-lint.yml",
"scss/**/*.scss",
"LICENSE"

This comment has been minimized.

@mdo

mdo Oct 1, 2017

Member

Shouldn't the license stay?

@mdo

mdo Oct 1, 2017

Member

Shouldn't the license stay?

This comment has been minimized.

@XhmikosR

XhmikosR Oct 1, 2017

Member

It's default included in npm.

@XhmikosR

XhmikosR Oct 1, 2017

Member

It's default included in npm.

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@twbs twbs deleted a comment from houndci-bot Oct 1, 2017

@mixin reset-text {
font-family: $font-family-base;
// We deliberately do NOT reset font-size or word-wrap.
font-style: normal;
font-weight: $font-weight-normal;
line-height: $line-height-base;
text-align: left; // Fallback for where `start` is not supported
text-align: start;
text-align: start; // stylelint-disable-line declaration-block-no-duplicate-properties

This comment has been minimized.

@houndci-bot

houndci-bot Oct 2, 2017

Property text-align already defined on line 7

@houndci-bot

houndci-bot Oct 2, 2017

Property text-align already defined on line 7

.navbar-collapse {
display: flex !important;
display: flex !important; // stylelint-disable-line declaration-no-important

This comment has been minimized.

@houndci-bot

houndci-bot Oct 2, 2017

!important should not be used

@houndci-bot

houndci-bot Oct 2, 2017

!important should not be used

@@ -89,7 +89,8 @@
.close {
padding: $modal-header-padding;
margin: (-$modal-header-padding) (-$modal-header-padding) (-$modal-header-padding) auto; // auto on the left force icon to the right even when there is no .modal-title
// auto on the left force icon to the right even when there is no .modal-title
margin: (-$modal-header-padding) (-$modal-header-padding) (-$modal-header-padding) auto;

This comment has been minimized.

@houndci-bot

houndci-bot Oct 2, 2017

Shorthands of length 4 are not allowed. Value was -$modal-header-padding -$modal-header-padding -$modal-header-padding auto

@houndci-bot

houndci-bot Oct 2, 2017

Shorthands of length 4 are not allowed. Value was -$modal-header-padding -$modal-header-padding -$modal-header-padding auto

.anchorjs-link {
font-weight: normal;
font-weight: 400;

This comment has been minimized.

@houndci-bot

houndci-bot Oct 2, 2017

Properties should be ordered color, font-weight, transition

@houndci-bot

houndci-bot Oct 2, 2017

Properties should be ordered color, font-weight, transition

@@ -25,7 +27,7 @@
display: none !important;
}
[class^=ds-dataset-] {
[class^="ds-dataset-"] {

This comment has been minimized.

@houndci-bot

houndci-bot Oct 2, 2017

Selector should have depth of applicability no greater than 2, but was 3

@houndci-bot

houndci-bot Oct 2, 2017

Selector should have depth of applicability no greater than 2, but was 3

@mixin reset-text {
font-family: $font-family-base;
// We deliberately do NOT reset font-size or word-wrap.
font-style: normal;
font-weight: $font-weight-normal;
line-height: $line-height-base;
text-align: left; // Fallback for where `start` is not supported
text-align: start;
text-align: start; // stylelint-disable-line declaration-block-no-duplicate-properties

This comment has been minimized.

@houndci-bot

houndci-bot Oct 2, 2017

Property text-align already defined on line 7

@houndci-bot

houndci-bot Oct 2, 2017

Property text-align already defined on line 7

.navbar-collapse {
display: flex !important;
display: flex !important; // stylelint-disable-line declaration-no-important

This comment has been minimized.

@houndci-bot

houndci-bot Oct 2, 2017

!important should not be used

@houndci-bot

houndci-bot Oct 2, 2017

!important should not be used

@@ -89,7 +89,8 @@
.close {
padding: $modal-header-padding;
margin: (-$modal-header-padding) (-$modal-header-padding) (-$modal-header-padding) auto; // auto on the left force icon to the right even when there is no .modal-title
// auto on the left force icon to the right even when there is no .modal-title
margin: (-$modal-header-padding) (-$modal-header-padding) (-$modal-header-padding) auto;

This comment has been minimized.

@houndci-bot

houndci-bot Oct 2, 2017

Shorthands of length 4 are not allowed. Value was -$modal-header-padding -$modal-header-padding -$modal-header-padding auto

@houndci-bot

houndci-bot Oct 2, 2017

Shorthands of length 4 are not allowed. Value was -$modal-header-padding -$modal-header-padding -$modal-header-padding auto

.anchorjs-link {
font-weight: normal;
font-weight: 400;

This comment has been minimized.

@houndci-bot

houndci-bot Oct 2, 2017

Properties should be ordered color, font-weight, transition

@houndci-bot

houndci-bot Oct 2, 2017

Properties should be ordered color, font-weight, transition

@@ -25,7 +27,7 @@
display: none !important;
}
[class^=ds-dataset-] {
[class^="ds-dataset-"] {

This comment has been minimized.

@houndci-bot

houndci-bot Oct 2, 2017

Selector should have depth of applicability no greater than 2, but was 3

@houndci-bot

houndci-bot Oct 2, 2017

Selector should have depth of applicability no greater than 2, but was 3

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Oct 2, 2017

Member

@mdo: is there anything else holding us for this? Otherwise pull the trigger 🔫

Member

XhmikosR commented Oct 2, 2017

@mdo: is there anything else holding us for this? Otherwise pull the trigger 🔫

@mdo mdo merged commit 7b766e1 into v4-dev Oct 3, 2017

3 of 4 checks passed

hound 5 violations found.
bundlesize Good job! bundle size < maxSize
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mdo mdo deleted the v4-dev-xmr-stylelint branch Oct 3, 2017

@mdo mdo referenced this pull request Oct 3, 2017

Closed

Beta 2 ship list #23278

@mdo mdo added this to Shipped in v4 Beta 2 Oct 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment