New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example plugin: add `data-example-id` only if it's been supplied. #24127

Merged
merged 3 commits into from Sep 27, 2017

Conversation

Projects
None yet
4 participants
@XhmikosR
Member

XhmikosR commented Sep 26, 2017

My Ruby knowledge is pretty basic, but this seems to do the job.

@XhmikosR XhmikosR added build v4 labels Sep 26, 2017

@XhmikosR XhmikosR requested review from mdo, bardiharborow and Johann-S Sep 26, 2017

@Johann-S

This comment has been minimized.

Show comment
Hide comment
@Johann-S

Johann-S Sep 27, 2017

Member

What's the goal of this PR @XhmikosR ?

Member

Johann-S commented Sep 27, 2017

What's the goal of this PR @XhmikosR ?

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Sep 27, 2017

Member

Without this, we insert data-example-id whenever the example filter is being used even without id being passed as a parameter.

Member

XhmikosR commented Sep 27, 2017

Without this, we insert data-example-id whenever the example filter is being used even without id being passed as a parameter.

@bardiharborow

My Ruby is terrible too, but I think I can get away with reviewing a ternary operator. :)

@XhmikosR XhmikosR merged commit 6dd3d91 into v4-dev Sep 27, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
hound No violations found. Woof!

@XhmikosR XhmikosR deleted the v4-dev-xmr-example-plugin branch Sep 27, 2017

@mdo mdo referenced this pull request Sep 27, 2017

Closed

Beta 2 ship list #23278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment