New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore CNAME #24379

Merged
merged 2 commits into from Oct 17, 2017

Conversation

Projects
None yet
2 participants
@XhmikosR
Member

XhmikosR commented Oct 15, 2017

Since the v4-dev branch will be eventually merged to master.

@XhmikosR XhmikosR added docs v4 labels Oct 15, 2017

@XhmikosR XhmikosR requested a review from mdo Oct 15, 2017

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Oct 15, 2017

Member

It's worth noting that even when restored via master, this won't have an impact on the gh-pages branch, as we don't merge from master for publishing the docs. Instead, it's a manual copy-pasta process, and the CNAME is already there.

Perhaps we nix it from the dev branch instead?

Member

mdo commented Oct 15, 2017

It's worth noting that even when restored via master, this won't have an impact on the gh-pages branch, as we don't merge from master for publishing the docs. Instead, it's a manual copy-pasta process, and the CNAME is already there.

Perhaps we nix it from the dev branch instead?

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Oct 16, 2017

Member

@mdo: if we delete it, then when the merge happens, it will be deleted in master too.

Member

XhmikosR commented Oct 16, 2017

@mdo: if we delete it, then when the merge happens, it will be deleted in master too.

@mdo

mdo approved these changes Oct 17, 2017

@XhmikosR XhmikosR merged commit 2c8bf6c into v4-dev Oct 17, 2017

4 checks passed

bundlesize Good job! bundle size < maxSize
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
hound No violations found. Woof!

@XhmikosR XhmikosR deleted the v4-dev-restore-cname branch Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment