Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Issue #24173 Custom checkboxes radios correct color #24401
Hi I took a look at this issue and I made the suggested changes to:
Custom Checkboxes/Radios Do Not Display Correct Color on :focus For Validation
Is this what you meant? Is there something else that needs to be done for this issue?
I welcome and look forward to your feedback.
Hey there @sabrown84, this is super close! There are two fixes we need you to make though before we can merge. The referenced issue is for the outline on focus of those fields, so we need to move this new rule to a different selector. Second is moving from hex values to some Sass variables.
I took a stab at outlining those changes in a couple comments—let me know if you have any questions about it!
Note for custom-file inputs, the focus styling will not work in Firefox, due to how Firefox treats what is "focused" in the native file input. Firefox focuses the button inside the file input and not the file input as a whole, so the sibling selector will not work in the Firefox case.
Firefox treats the file button and the filename label as two nested elements. Clicking the filename will cause a focus sibling selector to work, but clicking the browse button will not.