New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append btn-* and input-* variables and extends their from input-btn-*… #24430

Closed
wants to merge 2 commits into
base: v4-dev
from

Conversation

Projects
5 participants
@isychev

isychev commented Oct 19, 2017

Buttons and input inherit the padding from the $input-btn-padding-x and $input-btn-padding-y. For $input-btn-padding-y is entirely true, for there is a problem with $input-btn-padding-x, y buttons, large side indent and have indented input is much less.

Corrected this flaw and modified desires in #24265 (comment)

Fixes #23550.

@Johann-S Johann-S added css v4 labels Oct 19, 2017

@mdo mdo added this to Inbox in v4 Beta 3 Oct 19, 2017

@mdo mdo moved this from Inbox to Needs review in v4 Beta 3 Oct 19, 2017

@andresgalante

@mdo the "Buttons + Forms" section is a good solution to organize input variables before buttons
I tested it as much as I could and everything works as it should.
Big 👍 to this one.

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Oct 28, 2017

Member

So this is somehow merged into v4-dev now... I dunno how I screwed up the git history, but it's all outta whack in this PR. Good news is the changes are in v4-dev, so yay!

Member

mdo commented Oct 28, 2017

So this is somehow merged into v4-dev now... I dunno how I screwed up the git history, but it's all outta whack in this PR. Good news is the changes are in v4-dev, so yay!

@mdo mdo closed this Oct 28, 2017

@mdo mdo moved this from Needs review to Shipped in v4 Beta 3 Oct 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment