New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Approach docs page #25165

Merged
merged 13 commits into from Jan 14, 2018

Conversation

Projects
4 participants
@mdo
Member

mdo commented Jan 2, 2018

Super WIP, but the page exists with no outline at all. Adding one here to at least capture a few things.

@mdo mdo added docs v4 labels Jan 2, 2018

mdo added some commits Jan 2, 2018

@mdo mdo changed the title from Stub out a list for Approach docs page to Add new Approach docs page Jan 3, 2018

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Jan 3, 2018

Member

Pushed an extensive update here after the first outline. Would love feedback from @twbs/team on what else we should put here.

Member

mdo commented Jan 3, 2018

Pushed an extensive update here after the first outline. Would love feedback from @twbs/team on what else we should put here.

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jan 3, 2018

Member

I think it's a pretty good first approach 👍

Member

XhmikosR commented Jan 3, 2018

I think it's a pretty good first approach 👍

Specifically regarding custom CSS, utilities can help combat increasing file size by reducing your most commonly repeated property-value pairs into single classes. This can have a dramatic effect at scale in your projects.
## Flexible HTML

This comment has been minimized.

@andresgalante

andresgalante Jan 3, 2018

Member

Should we also mention that we never do type selectors, and elements are styled through classes.

@andresgalante

andresgalante Jan 3, 2018

Member

Should we also mention that we never do type selectors, and elements are styled through classes.

@mdo mdo added this to Inbox in v4.0 stable via automation Jan 11, 2018

@mdo mdo moved this from Inbox to Ready to merge in v4.0 stable Jan 11, 2018

XhmikosR added some commits Jan 11, 2018

@mdo mdo referenced this pull request Jan 12, 2018

Closed

v4.0.0 ship list #25098

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jan 12, 2018

Member

@mdo: is this ready to merge?

Member

XhmikosR commented Jan 12, 2018

@mdo: is this ready to merge?

@patrickhlauke patrickhlauke self-requested a review Jan 12, 2018

@patrickhlauke

In future, perhaps something generic about Bootstrap trying to be a generic foundation, rather than trying to solve every possible use case. That authors need to still make sure they use good semantic markup. And cross-reference to the accessibility page? But as a starting point, this is great.

mdo and others added some commits Jan 13, 2018

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jan 13, 2018

Member

@mdo: anyway, I'll leave this for you to merge, just please make sure you squash when merging.

Member

XhmikosR commented Jan 13, 2018

@mdo: anyway, I'll leave this for you to merge, just please make sure you squash when merging.

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Jan 13, 2018

Member

Was reviewing last night and fell asleep without hitting submit. 😆 This should be good to go now. I'm reviewing some issues and PRs and going to get some things merged today.

Member

mdo commented Jan 13, 2018

Was reviewing last night and fell asleep without hitting submit. 😆 This should be good to go now. I'm reviewing some issues and PRs and going to get some things merged today.

@XhmikosR XhmikosR merged commit 71550d3 into v4-dev Jan 14, 2018

3 checks passed

bundlesize Good job! bundle size < maxSize
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

v4.0 stable automation moved this from Ready to merge to Shipped Jan 14, 2018

@XhmikosR XhmikosR deleted the approach branch Jan 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment