New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shipping v3.4.0 #26212
Shipping v3.4.0 #26212
Conversation
…g to prevent early navbar breakage in responsive viewports
|
@mdo: please make a dist here before merging. Just make sure you nuke your local node_modules and you don't commit package-lock.json by accident. |
|
I made https://github.com/twbs/bootstrap/tree/v3.4.0-dev-rebased which is rebased against master. I haven't verified if all is good. But we could switch the PR to that branch if there's no issue. |
* fix(collapse): xss CVE-2018-14040 Fixes #26625 * fix(tooltip): xss CVE-2018-14042 Fixes #26628 * fix(tooltip): XSS on data-viewport attribute Fixes #27044 * fix(affix): XSS on target config Fixes #27045
|
Biggest blocker here is failing tests. Anyone have any insights? Been years since we've dug into this build tooling, but if we can figure that out, we can likely do a release. |
|
@mdo there are unit test which fail on some browser, I'm on it |
|
We had unit tests which failed, it's not the case currently because we have a Sauce Labs bug (yeaah again https://saucelabs.com/beta/tests/e4851fc38f99456b8166684b393c3a6a/watch Maybe we need to update some of our deps /CC @XhmikosR |
|
Spent a few hours today, made some progress so we should have this soon :D |
|
I have two unit tests which fail locally but I'm near the end too |
|
@mdo: docs search seems broken, at least locally. |
|
I backported my patches for search from v4 in my WIP v3 branch. There are some issues though:
|
Oh hey, it's been awhile since we shipped a v3.x release. While it's no longer our focus with v4 being out and stable, we can still get some wins by shipping some quality of life updates. Here's what's included in this update.
.row-no-guttersclass.<abbr>elements./docs/3.4, for that versioning life when we deploy to GitHub Pages.There's a bit more in here yet, but those are the highlights thus far. Still have some more to come I think, but wanted to have this open for tracking purposes.
TODO: