Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping v3.4.0 #26212

Merged
merged 73 commits into from Sep 20, 2018
Merged

Shipping v3.4.0 #26212

merged 73 commits into from Sep 20, 2018

Conversation

mdo
Copy link
Member

@mdo mdo commented Apr 7, 2018

Oh hey, it's been awhile since we shipped a v3.x release. While it's no longer our focus with v4 being out and stable, we can still get some wins by shipping some quality of life updates. Here's what's included in this update.

  • 29f9237, 13bf8ae fixed XSS issue in Alert, Carousel, Collapse, Dropdown, Modal and Tab components.
  • 48f1482 added a .row-no-gutters class.
  • 7011e27 removes the double border on <abbr> elements.
  • 1802075 adds some system fonts, though we may want to remove these considering the older browser and OS support.
  • 4f4592c and subsequent commits reorganized the v3 docs CSS to use Less.
  • 1d83280 added a dropdown to the docs nav for newer and previous versions.
  • 059969b updates the docs to use a new baseurl, /docs/3.4, for that versioning life when we deploy to GitHub Pages.

There's a bit more in here yet, but those are the highlights thus far. Still have some more to come I think, but wanted to have this open for tracking purposes.

TODO:

  • Fix any 404s and useless redirects
  • Remove customizer's gist creation
  • Fix docs search
  • Verify everything is good with the builds
  • Verify sourcemaps work
  • Fix Browser tests
  • Rebase the branch against master

@twbs twbs locked and limited conversation to collaborators Apr 7, 2018
@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Apr 7, 2018

@mdo: please make a dist here before merging.

Just make sure you nuke your local node_modules and you don't commit package-lock.json by accident.

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Apr 7, 2018

I made https://github.com/twbs/bootstrap/tree/v3.4.0-dev-rebased which is rebased against master. I haven't verified if all is good. But we could switch the PR to that branch if there's no issue.

@mdo
Copy link
Member Author

@mdo mdo commented Aug 19, 2018

Biggest blocker here is failing tests. Anyone have any insights? Been years since we've dug into this build tooling, but if we can figure that out, we can likely do a release.

@Johann-S
Copy link
Member

@Johann-S Johann-S commented Aug 19, 2018

@mdo there are unit test which fail on some browser, I'm on it

@Johann-S
Copy link
Member

@Johann-S Johann-S commented Aug 19, 2018

We had unit tests which failed, it's not the case currently because we have a Sauce Labs bug (yeaah again 😆 ) a lots of our tests end in success but Sauce Labs isn't able to detect it see for example:

https://saucelabs.com/beta/tests/e4851fc38f99456b8166684b393c3a6a/watch
https://saucelabs.com/beta/tests/12757eaf06d04c61a6e0bc5dbe50bd60/watch

Maybe we need to update some of our deps 🤔

/CC @XhmikosR

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Sep 18, 2018

Spent a few hours today, made some progress so we should have this soon :D

@Johann-S
Copy link
Member

@Johann-S Johann-S commented Sep 18, 2018

I have two unit tests which fail locally but I'm near the end too

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Sep 20, 2018

@mdo: docs search seems broken, at least locally.

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Sep 20, 2018

I backported my patches for search from v4 in my WIP v3 branch. There are some issues though:

  • the index is for 3.4 which doesn't exit on Algolia
  • the results might need some styling

@XhmikosR XhmikosR merged commit 9c4c72e into master Sep 20, 2018
0 of 2 checks passed
@XhmikosR XhmikosR deleted the v3.4.0-dev branch Sep 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants