New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus on custom-file input in Firefox #26576

Open
wants to merge 4 commits into
base: v4-dev
from

Conversation

Projects
None yet
6 participants
@alecpl

alecpl commented May 24, 2018

Fixes #26563.

alecpl added some commits May 24, 2018

@alecpl

This comment has been minimized.

alecpl commented May 24, 2018

I noticed that there are two more issues:

  1. Similar hack might be needed for form validation classes
  2. $enable-shadows is ignored on custom-file input focus
    Feel free to take over the PR to fix these.
@ysds

This comment has been minimized.

Contributor

ysds commented May 24, 2018

I know it is an edge case, but :focus-within causes double focus ring if .custom-file contains other focusable elements.

image

https://codepen.io/anon/pen/GdaGeL

@alecpl

This comment has been minimized.

alecpl commented May 25, 2018

@ysds, a valid one, I didn't find solution for this case.

@mdo mdo added this to Inbox in v4.1.3 via automation Jul 9, 2018

@mdo mdo moved this from Inbox to Needs review in v4.1.3 Jul 9, 2018

@mdo

This comment has been minimized.

Member

mdo commented Jul 15, 2018

Similar hack might be needed for form validation classes

Yup, we definitely need this, too.

@mdo mdo removed this from Needs review in v4.1.3 Jul 15, 2018

@XhmikosR

This comment was marked as outdated.

Member

XhmikosR commented Oct 23, 2018

@alecpl: can you fetch upstream and rebase?

@alecpl

This comment was marked as outdated.

alecpl commented Oct 23, 2018

I could, but as you can read here it's not a full fix. So, I hope someone could just use it as an idea for a proper fix.

@XhmikosR

This comment was marked as outdated.

Member

XhmikosR commented Oct 23, 2018

The reason I asked for it is so that we have a Netlify preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment