Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tooltip docs to explain potential overflow boundary issue #26844

Merged
merged 4 commits into from Jul 20, 2018
Merged

Update tooltip docs to explain potential overflow boundary issue #26844

merged 4 commits into from Jul 20, 2018

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jul 10, 2018

Fixes #26836

Following #26842

#26836 (comment)

image

Copy link
Member

@Johann-S Johann-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the change on assets/css/docs.min.css

@XhmikosR
Copy link
Member

@Johann-S: I can't confirm what this documents is right, can you confirm?

@simPod
Copy link
Contributor Author

simPod commented Jul 10, 2018

@XhmikosR XhmikosR added this to Inbox in v4.1.3 via automation Jul 10, 2018
{% capture callout %}
##### Usage with overflow `auto` and `scroll`

When the parent container has the CSS property `overflow` set to values `auto` or `scroll` (for example when used within `.table-responsive`) the tooltip has weird flickering behaviour.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's describe what happens instead of saying "it has weird behavior." The current suggestion indicates we have no idea why it happens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the parent container has the CSS property overflow set to values auto or scroll (for example when used within .table-responsive) the tooltip's placement changes to bottom but still keeps original placement's positioning.

but that sounds a bit weird as we're documenting a bug :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We describe a particular use case to help folks

@mdo mdo moved this from Inbox to Ready to merge in v4.1.3 Jul 16, 2018
@mdo mdo changed the title Update docs Update tooltip docs to explain potential overflow boundary issue Jul 20, 2018
@mdo mdo merged commit a4b2e39 into twbs:v4-dev Jul 20, 2018
v4.1.3 automation moved this from Ready to merge to Shipped Jul 20, 2018
@mdo mdo mentioned this pull request Jul 20, 2018
@simPod simPod deleted the document-tooltip-flickering branch July 20, 2018 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.1.3
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

4 participants