New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selector improvement linked badge #27219

Merged
merged 1 commit into from Sep 14, 2018

Conversation

Projects
3 participants
@MartijnCuppens
Contributor

MartijnCuppens commented Sep 13, 2018

Selector improvement, isolated from PR #27136

a.badge instead of .badge[href]

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Sep 14, 2018

Member

@MartijnCuppens: could you try if the Sass gem builds everything right too?

Member

XhmikosR commented Sep 14, 2018

@MartijnCuppens: could you try if the Sass gem builds everything right too?

@XhmikosR XhmikosR requested review from andresgalante and mdo Sep 14, 2018

@XhmikosR XhmikosR added css v4 labels Sep 14, 2018

@XhmikosR XhmikosR added this to Inbox in v4.2 via automation Sep 14, 2018

@MartijnCuppens

This comment has been minimized.

Show comment
Hide comment
@MartijnCuppens

MartijnCuppens Sep 14, 2018

Contributor

@XhmikosR I've run the command sass scss/bootstrap.scss:dist/css/bootstrap.css this also returns the expected result, was this what you wanted to be tested?

Contributor

MartijnCuppens commented Sep 14, 2018

@XhmikosR I've run the command sass scss/bootstrap.scss:dist/css/bootstrap.css this also returns the expected result, was this what you wanted to be tested?

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Sep 14, 2018

Member

Yup, all good thanks!

Member

XhmikosR commented Sep 14, 2018

Yup, all good thanks!

@andresgalante andresgalante merged commit 7a01f3c into twbs:v4-dev Sep 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.675%
Details

v4.2 automation moved this from Inbox to Shipped Sep 14, 2018

@mdo mdo referenced this pull request Sep 14, 2018

Open

v4.2.0 shiplist #26952

@MartijnCuppens MartijnCuppens deleted the MartijnCuppens:badge-selector branch Sep 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment