New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.4.0 #27288

Merged
merged 5 commits into from Dec 13, 2018

Conversation

Projects
None yet
3 participants
@XhmikosR
Copy link
Member

XhmikosR commented Sep 21, 2018

@mdo @Johann-S

TODO:

  • Fix any 404s and useless redirects
  • Remove customizer's gist creation
  • Fix Browser tests
  • Go back to single colon pseudo elements for backwards compatibility with the browsers we support in v3
  • Fix docs search
  • Replace ZeroClipboard with clipboards.js since Flash is dead
  • Tweak clipboard.js styles
  • Update team
  • Nuke jobs from docs
  • Add the unprefixed appearance property
  • Add BrowserStack thanks in README.md
  • Exclude docs less files from Jekyll
  • Test builds with real apps just in case
  • Verify sourcemaps work
  • Customizer: remove drag and drop support and references, or fix this
  • Make sure the SRI hashes are updated and correct!
  • Make a dist commit on non-Windows and make sure there are no modifications; if there are, commit them, then rebase the branch
  • Detailed references to the XSS fixes for each component in release notes/post
  • Merge algolia/docsearch-configs#577 after the release is live

Ship list:

  • 29f9237, 13bf8ae fixed XSS issue in Alert, Carousel, Collapse, Dropdown, Modal and Tab components, see https://snyk.io/vuln/npm:bootstrap:20160627.
  • 48f1482 added a .row-no-gutters class.
  • cf6f867 Add padding to navbar-fixed-* on modal open
  • 4f4592c and subsequent commits reorganized the v3 docs CSS to use Less.
  • 1d83280 added a dropdown to the docs nav for newer and previous versions.
  • 059969b update the docs to use a new baseurl, /docs/3.4, for that versioning life when we deploy to GitHub Pages.
  • 4ebe2b8 switch to BrowserStack for tests
  • e105d15 use https/fix broken links in docs
  • 25d017a replace ZeroClipboard with clipboard.js
  • d7ab2fb remove gist creation in customizer since anonymous gists are disabled by GitHub
  • b304c61 remove drag and drop support from customizer since it didn't work anymore
  • d24d47c Add docs searching via Algolia
  • Remove the double border on <abbr> elements.

Closes #25679.

Docs Preview: https://twbs-340.netlify.com/

@twbs twbs locked and limited conversation to collaborators Sep 21, 2018

@XhmikosR XhmikosR changed the title Release next v3 Release v3.4.0 Sep 21, 2018

@XhmikosR XhmikosR force-pushed the master-xmr-v3-fixes branch 16 times, most recently from bbbd615 to 10c03c9 Sep 21, 2018

@Johann-S

This comment has been minimized.

Copy link
Member

Johann-S commented Sep 23, 2018

Tests I did:

  • v3.4.0 works well with jQuery 3
  • Our JS works well
  • Tested the build

@XhmikosR XhmikosR force-pushed the master-xmr-v3-fixes branch from 339ec45 to 4b27511 Sep 23, 2018

@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Sep 23, 2018

All good then, I also tested the build with Chrome and FF in an app of mine. I didn't try IE at all though, I will try it later.

So, only sourcemaps testing is left and a couple of docs styling from @mdo.

EDIT: Oh, and docs searching :D

@XhmikosR XhmikosR force-pushed the master-xmr-v3-fixes branch 7 times, most recently from bc16020 to c83fea2 Sep 23, 2018

@XhmikosR XhmikosR force-pushed the master-xmr-v3-fixes branch 2 times, most recently from 44075d9 to 52579f0 Nov 1, 2018

@mdo

This comment has been minimized.

Copy link
Member

mdo commented Nov 3, 2018

Spun this up locally today...

  • I had to install karma-cli globally to get grunt to run—it'd fail every time trying to run Karma tests otherwise. Are we missing a declared dependency?

  • Need to update the ship list to exclude the mention of native font stack—I unshipped that a bit ago because of concerns around old browsers and OSes.

  • Need to update the local dev docs in the readme to point to the correct localhost URL (e.g., it's no longer just http://0.0.0.0:9001/ but http://0.0.0.0:9001/docs/3.4/).

  • Should we point the About page link in the footer to the v4.x about pages? I don't want to get into the habit of maintaining two versions of the team pages, for example.

Otherwise, I think this looks good!

@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Nov 3, 2018

@mdo

  1. not true, something on your side for sure
  2. your call :)
  3. your call also
  4. well that's a tricky thing. Because we can't always point to the latest docs and this was basically an old branch with other people involved anyway

@XhmikosR XhmikosR force-pushed the master-xmr-v3-fixes branch 2 times, most recently from b792cca to 0af7e44 Nov 5, 2018

avkash4n4u referenced this pull request Nov 9, 2018

Fix/xss issues on data attributes (#27047)
* fix(collapse): xss CVE-2018-14040

Fixes #26625

* fix(tooltip): xss CVE-2018-14042

Fixes #26628

* fix(tooltip): XSS on data-viewport attribute

Fixes #27044

* fix(affix): XSS on target config

Fixes #27045

@XhmikosR XhmikosR force-pushed the master-xmr-v3-fixes branch from 0af7e44 to 5901bcb Nov 10, 2018

@XhmikosR XhmikosR force-pushed the master-xmr-v3-fixes branch 4 times, most recently from e876ccb to 17e3ab2 Nov 18, 2018

@XhmikosR XhmikosR force-pushed the master-xmr-v3-fixes branch 3 times, most recently from ed46b67 to be8ac85 Nov 30, 2018

@XhmikosR XhmikosR force-pushed the master-xmr-v3-fixes branch 5 times, most recently from 7b69152 to 329866c Dec 10, 2018

XhmikosR added some commits Sep 18, 2018

Update devDependencies, gems and lots of cleanup/build fixes.
* switch to grunt-postcss and autoprefixer directly; this is the recommended way.
* uglify: specify `ie8` for compatibility
* specify `cascade:false` for autoprefixer
* specify `ieCompat` for less
* drop grunt-contrib-compress since it doesn't work with Node.js 10.x
* remove grunt-contrib-htmlmin to match the v4 docs
* clean up Gruntfile.js
* clean up .travis.yml and backport changes from v4
* build ie10-viewport-bug-workaround.less since it's used in examples
* move shrinkwrap to root
* bs-commonjs-generator.js: Use `path.posix`
* remove .hound.yml
* remove references to no longer used PR bots
* backport and adapt the sri generation script from v4
Add polyfills for older browsers.
requestAnimationFrame and btoa.

@XhmikosR XhmikosR force-pushed the master-xmr-v3-fixes branch from 329866c to 4960e07 Dec 12, 2018

@mdo

mdo approved these changes Dec 13, 2018

Copy link
Member

mdo left a comment

🤘

@XhmikosR XhmikosR merged commit 4c547f2 into master Dec 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@XhmikosR XhmikosR deleted the master-xmr-v3-fixes branch Dec 13, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.